[1.3][CVE-2023-0842] Bump xml2js from 0.4.22 to 0.6.2 #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
added
cve
ananzh
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Signed-off-by: ananzh <ananzh@amazon.com>
ZilongX
previously approved these changes
Sep 14, 2023
joshuarrrr
reviewed
Sep 14, 2023
CHANGELOG.md
Outdated
| @@ -36,6 +36,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - [CVE-2022-1537] Bump grunt from `1.4.1` to `1.5.3` ([#3723](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3723)) | |||
| - [CVE-2022-0436] Bump grunt from `1.4.1` to `1.5.3` ([#3723](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3723)) | |||
| - [CVE-2023-26136] Resolve `tough-cookie` to `4.1.3` ([#4682](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4682)) | |||
| - [CVE-2023-0842] Bump `xml2js` from `0.4.22` to `0.6.2` ([#5024](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5024)) | |||
There was a problem hiding this comment.
Wrong section - should be under L10.
There was a problem hiding this comment.
eeeee... I need to fix others. thank you.
yarn.lock
Outdated
| @@ -22297,7 +22297,7 @@ xml-parse-from-string@^1.0.0: | |||
| resolved "https://registry.yarnpkg.com/xml-parse-from-string/-/xml-parse-from-string-1.0.1.tgz#a9029e929d3dbcded169f3c6e28238d95a5d5a28" | |||
| integrity sha1-qQKekp09vN7RafPG4oI42VpdWig= | |||
|
|
|||
| xml2js@^0.4.22, xml2js@^0.4.5: | |||
| xml2js@^0.4.5: | |||
| version "0.4.22" | |||
There was a problem hiding this comment.
It looks like we still have a sub-dep requiring 0.4.22. To resolve the CVE, do we need to force a resolution?
There was a problem hiding this comment.
Yeah you are right. it is brought in by
=> Found "parse-bmfont-xml#xml2js@0.4.23"
info This module exists because "_project_#jimp#@jimp#plugins#@jimp#plugin-print#load-bmfont#parse-bmfont-xml" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "504KB"
info Disk size with transitive dependencies: "504KB"
info Number of shared dependencies: 2
with the latest jimp, we still see xml2js@0.4.23. have to force a resolution. Thank you for checking this carefully. ❤️
Codecov Report
@@ Coverage Diff @@
## 1.3 #5024 +/- ##
==========================================
+ Coverage 67.45% 67.50% +0.04%
==========================================
Files 3044 3044
Lines 58692 58692
Branches 8902 8902
==========================================
+ Hits 39593 39619 +26
+ Misses 16946 16925 -21
+ Partials 2153 2148 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
AMoo-Miki
approved these changes
Sep 15, 2023
kavilla
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
SemVerphilosophy, when releasing a patch version, it should not introduce breaking changes, which includes bumping a dependency to its major version.xml2jsis a dev dependency in both OSD and package@osd/test. Meanwhile, it is not included in release artifact. Therefore, bumping major versions should not breakSemVerrules.Description
Due to Leonidas-from-XIV/node-xml2js#672 (comment) , try bump
xml2jsto0.6.2to solve cve and avoid regression errors.Issues Resolved
CVE-2023-0842
#3793
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr