[Data Explorer][Discover] Fix total hits issue for no time based data #5087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
ananzh
changed the title
ananzh
added
bug
Codecov Report
@@ Coverage Diff @@
## main #5087 +/- ##
==========================================
- Coverage 66.50% 66.48% -0.02%
==========================================
Files 3403 3403
Lines 65026 65026
Branches 10401 10401
==========================================
- Hits 43243 43232 -11
- Misses 19214 19224 +10
- Partials 2569 2570 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Issue Resolve opensearch-project#5068 Signed-off-by: ananzh <ananzh@amazon.com>
ashwin-pc
approved these changes
Sep 21, 2023
abbyhu2000
approved these changes
Sep 22, 2023
abbyhu2000
pushed a commit
that referenced
this pull request
Sep 26, 2023
Issue Resolve #5068 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit a10f1c7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolve
#5068
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr