[Tests-refactor] Remove angular code from plugin_functional and update tests #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
ananzh
changed the title
…e tests * remove angular-based view from DocViewsPlugin * remove the test case that validates the display and content of the angular doc view Issue Resolve opensearch-project#5020 Signed-off-by: ananzh <ananzh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #5221 +/- ##
==========================================
- Coverage 66.76% 66.76% -0.01%
==========================================
Files 3278 3278
Lines 62999 63008 +9
Branches 10031 10034 +3
==========================================
+ Hits 42059 42065 +6
- Misses 18473 18554 +81
+ Partials 2467 2389 -78
Flags with carried forward coverage won't be shown. Click here to find out more. |
curq
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
…e tests (#5221) * remove angular-based view from DocViewsPlugin * remove the test case that validates the display and content of the angular doc view Issue Resolve #5020 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 70b9eea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Oct 5, 2023
…e tests (#5221) (#5224) * remove angular-based view from DocViewsPlugin * remove the test case that validates the display and content of the angular doc view Issue Resolve #5020 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 70b9eea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
willie-hung
pushed a commit
to willie-hung/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2023
…e tests (opensearch-project#5221) * remove angular-based view from DocViewsPlugin * remove the test case that validates the display and content of the angular doc view Issue Resolve opensearch-project#5020 Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: Willie Hung <willie880201044@gmail.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 7, 2023
…e tests (opensearch-project#5221) * remove angular-based view from DocViewsPlugin * remove the test case that validates the display and content of the angular doc view Issue Resolve opensearch-project#5020 Signed-off-by: ananzh <ananzh@amazon.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue Resolved
#5020
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr