[CI] Cypress tests support ciGroups #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
requested review from
ananzh,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
|
Works with the manual run need to verify with PRs |
Partially resolves: opensearch-project#5297 Add ciGroups to handle the increase in tests added which also impact the allocation available on the machines that run these tests. However, this deserves to be more optimized and utilized within the build infra repo so that we can ensure that release testing is also leverging ciGroups within plugins. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
kavilla/cypress_ci_groups
branch
from
cff77a3
to
44a658e
Compare
kavilla
commented
Oct 13, 2023
|
|
||
| env: | ||
| TEST_REPO: ${{ inputs.test_repo != '' && inputs.test_repo || 'opensearch-project/opensearch-dashboards-functional-test' }} | ||
| TEST_BRANCH: "${{ inputs.test_branch != '' && inputs.test_branch || github.base_ref }}" | ||
| FTR_PATH: 'ftr' | ||
| START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch' | ||
| START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch --savedObjects.maxImportPayloadBytes=10485760 --server.maxPayloadBytes=1759977 --logging.json=false --data.search.aggs.shardDelay.enabled=true' |
There was a problem hiding this comment.
@manasvinibs we should consider be able to distributing a common config like selenium tests.
kavilla
commented
Oct 13, 2023
| @@ -179,8 +198,6 @@ jobs: | |||
|
|
|||
| #### Inputs: | |||
| ``` | |||
| Source repo: '${{ env.SOURCE_REPO }}' | |||
There was a problem hiding this comment.
Got rid of this because unless set at a file level github env variables do not share between jobs. This information is already available within the test run.
Codecov Report
@@ Coverage Diff @@
## main #5298 +/- ##
==========================================
+ Coverage 66.73% 66.77% +0.03%
==========================================
Files 3284 3284
Lines 63095 63095
Branches 10049 10049
==========================================
+ Hits 42108 42132 +24
+ Misses 18589 18495 -94
- Partials 2398 2468 +70
Flags with carried forward coverage won't be shown. Click here to find out more. |
abbyhu2000
approved these changes
Oct 13, 2023
ananzh
approved these changes
Oct 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
Partially resolves: #5297 Add ciGroups to handle the increase in tests added which also impact the allocation available on the machines that run these tests. However, this deserves to be more optimized and utilized within the build infra repo so that we can ensure that release testing is also leverging ciGroups within plugins. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 7a964b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
Partially resolves: #5297 Add ciGroups to handle the increase in tests added which also impact the allocation available on the machines that run these tests. However, this deserves to be more optimized and utilized within the build infra repo so that we can ensure that release testing is also leverging ciGroups within plugins. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 7a964b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
abbyhu2000
pushed a commit
that referenced
this pull request
Oct 19, 2023
Partially resolves: #5297 Add ciGroups to handle the increase in tests added which also impact the allocation available on the machines that run these tests. However, this deserves to be more optimized and utilized within the build infra repo so that we can ensure that release testing is also leverging ciGroups within plugins. (cherry picked from commit 7a964b6) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Oct 19, 2023
Partially resolves: #5297 Add ciGroups to handle the increase in tests added which also impact the allocation available on the machines that run these tests. However, this deserves to be more optimized and utilized within the build infra repo so that we can ensure that release testing is also leverging ciGroups within plugins. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 7a964b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ciGroups to handle the increase in tests added which also impact the allocation available on the machines that run these tests.
However, this deserves to be more optimized and utilized within the build infra repo so that we can ensure that release testing is also leverging ciGroups within plugins.
Issues Partially Resolved
#5297
Check List
yarn test:jestyarn test:jest_integration