Replace OuiSelect component with OuiSuperSelect in data-source plugin #5315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5315 +/- ##
==========================================
- Coverage 67.02% 67.02% -0.01%
==========================================
Files 3294 3294
Lines 63309 63307 -2
Branches 10071 10071
==========================================
- Hits 42435 42430 -5
- Misses 18430 18431 +1
- Partials 2444 2446 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bandinib-amzn
force-pushed
the
ux-fix
branch
3 times, most recently
from
6abe9f8
to
d6514c4
Compare
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
bandinib-amzn
force-pushed
the
ux-fix
branch
from
d6514c4
to
3a92b38
Compare
bandinib-amzn
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq and
SuZhou-Joe
as code owners
Flyingliuhub
approved these changes
Dec 21, 2023
ZilongX
approved these changes
Jan 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
…#5315) * Replace OuiSelect component with OuiSuperSelect in data-source plugin Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Fix UT Signed-off-by: Bandini Bhopi <bandinib@amazon.com> --------- Signed-off-by: Bandini Bhopi <bandinib@amazon.com> (cherry picked from commit 18607a2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6 tasks
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
…#5315) (#5666) * Replace OuiSelect component with OuiSuperSelect in data-source plugin * Fix UT --------- (cherry picked from commit 18607a2) Signed-off-by: Bandini Bhopi <bandinib@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
OuiSelectcomponent withOuiSuperSelectin data-source pluginScreenshot
Check List
yarn test:jestyarn test:jest_integration