-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint-import-resolver-webpack
and browserify-sign
#5414
Bump eslint-import-resolver-webpack
and browserify-sign
#5414
Conversation
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #5414 +/- ##
==========================================
- Coverage 66.83% 66.81% -0.02%
==========================================
Files 3288 3288
Lines 63151 63151
Branches 10054 10054
==========================================
- Hits 42206 42196 -10
- Misses 18463 18478 +15
+ Partials 2482 2477 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-5414-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 088fc667c2ae480a007fbb0a76b96bbf9439f676
# Push it to GitHub
git push --set-upstream origin backport/backport-5414-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5414-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 088fc667c2ae480a007fbb0a76b96bbf9439f676
# Push it to GitHub
git push --set-upstream origin backport/backport-5414-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Backport PR: opensearch-project#5414 Signed-off-by: ananzh <ananzh@amazon.com>
Backport PR opensearch-project#5414 Signed-off-by: ananzh <ananzh@amazon.com>
Backport PR: #5414 Signed-off-by: ananzh <ananzh@amazon.com>
Backport PR #5414 Signed-off-by: ananzh <ananzh@amazon.com>
…#5483) Backport PR: #5414 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 90b0d02) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <miki@amazon.com>
Description
eslint-import-resolver-webpack
bump removes nested dep ofbrowserify-sign
browserify-sign
, just updated yarn.lock to compatible fixed patch version.Issues Resolved
Fixes #5410
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration