[Backport 2.x] [Workspace] Feature/workspace service core module #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* feat: add core workspace module (#145) The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations. This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application. Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 9e3e3a7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5416 +/- ##
==========================================
- Coverage 67.01% 67.01% -0.01%
==========================================
Files 3289 3291 +2
Lines 63304 63338 +34
Branches 10057 10061 +4
==========================================
+ Hits 42426 42446 +20
- Misses 18439 18452 +13
- Partials 2439 2440 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Whitesource failure can be ignored. |
ananzh
previously approved these changes
Dec 12, 2023
SuZhou-Joe
previously approved these changes
Dec 13, 2023
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
opensearch-trigger-bot
bot
requested review from
curq and
bandinib-amzn
as code owners
Fix lint Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <miki@amazon.com>
manasvinibs
approved these changes
Dec 13, 2023
ananzh
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9e3e3a7 from #5092.