Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Inactive State on 'Discover' Tab in Side Navigation Menu #5432

Merged
merged 13 commits into from
Dec 13, 2023
Merged

[Fix] Inactive State on 'Discover' Tab in Side Navigation Menu #5432

merged 13 commits into from
Dec 13, 2023
+73 −1

Commits on Nov 5, 2023

  1. Fix active background render error 

    Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung
    willie-hung committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    8745b7b View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung
    willie-hung committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    0378e8b View commit details
    Browse the repository at this point in the history

  3. Revise test suit 

    Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung
    willie-hung committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    e69ff56 View commit details
    Browse the repository at this point in the history

  4. Add isActive logic 

    Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung
    willie-hung committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    4cd1632 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Merge branch 'main' into bug/discover-tab 

    Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8f1bedf View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Remove redundant tests and add comment for future reference 

    Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung
    willie-hung committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    aa623d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Update src/core/public/chrome/ui/header/nav_link.tsx 

    Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung @joshuarrrr
    willie-hung and joshuarrrr authored Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6dae6d1 View commit details
    Browse the repository at this point in the history

  2. Seperate special cases from logic && revise test 

    Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung
    willie-hung committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    d05929e View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md 

    Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung
    willie-hung committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b222fd3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Merge branch 'main' into bug/discover-tab 

    Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    dbe169b View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Merge branch 'main' into bug/discover-tab

    @joshuarrrr
    joshuarrrr authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    778de06 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'main' into bug/discover-tab

    @joshuarrrr
    joshuarrrr authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f97c452 View commit details
    Browse the repository at this point in the history

  2. Update src/core/public/chrome/ui/header/nav_link.tsx 

    Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
    @willie-hung @SuZhou-Joe
    willie-hung and SuZhou-Joe authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a37d42c View commit details
    Browse the repository at this point in the history