Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance darwin-arm64 release #5455

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Enhance darwin-arm64 release #5455

merged 1 commit into from
Nov 10, 2023

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Nov 9, 2023 •
edited
Loading

Description

Enhance darwin-arm64 release

  • Add min-builds for darwin-x64 and darwin-arm64.
  • Expose --darwin-arm as a parameter of the build script.
  • Work around build's cleanup failure when removal of an already deleted folder is attempted.
  • Exclude bundling fallbacks with darwin-arm64 since Node.js v14 has no releases for them.
  • Update tests to accommodate darwin-arm64.
  • Generalize the Node.js versions used in some tests.

PS: Skipping changelog as this is an enhancement to a recent change that was merged [#5290]

Issues Resolved

Fixes #5413
Succeeds #5424

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki AMoo-Miki added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Nov 9, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #5455 (02f301c) into main (088fc66) will increase coverage by 7.74%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #5455      +/-   ##
==========================================
+ Coverage   59.07%   66.82%   +7.74%     
==========================================
  Files        2981     3291     +310     
  Lines       56492    63180    +6688     
  Branches     8714    10057    +1343     
==========================================
+ Hits        33372    42219    +8847     
+ Misses      21362    18479    -2883     
- Partials     1758     2482     +724
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.28% <ø> (?)
Linux_3 43.81% <ø> (?)
Linux_4 35.35% <66.66%> (+0.01%) ⬆️
Windows_1 35.26% <ø> (?)
Windows_2 55.25% <ø> (ø)
Windows_3 43.81% <ø> (?)
Windows_4 35.35% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dev/build/args.ts 84.21% <ø> (ø)
...ev/build/tasks/nodejs/download_node_builds_task.ts 100.00% <100.00%> (ø)
...dev/build/tasks/nodejs/extract_node_builds_task.ts 100.00% <100.00%> (ø)
src/dev/build/lib/fs.ts 18.91% <0.00%> (ø)

... and 725 files with indirect coverage changes

@AMoo-Miki
Enhance darwin-arm64 release
02f301c 
* Add min-builds for `darwin-x64` and `darwin-arm64`.
* Expose `--darwin-arm` as a parameter of the build script.
* Work around build's cleanup failure when removal of an already deleted folder is attempted.
* Exclude bundling fallbacks with `darwin-arm64` since Node.js v14 has no releases for them.
* Update tests to accommodate `darwin-arm64`.
* Generalize the Node.js versions used in some tests.

Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki force-pushed the exclude-darwin-arm64-fallback branch from 0818c66 to 02f301c Compare November 9, 2023 23:02
@ananzh ananzh merged commit 89dc051 into opensearch-project:main Nov 10, 2023
74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2023
@github-actions
Enhance darwin-arm64 release (#5455)
827dd5b 
* Add min-builds for `darwin-x64` and `darwin-arm64`.
* Expose `--darwin-arm` as a parameter of the build script.
* Work around build's cleanup failure when removal of an already deleted folder is attempted.
* Exclude bundling fallbacks with `darwin-arm64` since Node.js v14 has no releases for them.
* Update tests to accommodate `darwin-arm64`.
* Generalize the Node.js versions used in some tests.

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 89dc051)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 10, 2023
Closed
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 13, 2023
@AMoo-Miki
Enhance darwin-arm64 release (opensearch-project#5455)
30892ed 
* Add min-builds for `darwin-x64` and `darwin-arm64`.
* Expose `--darwin-arm` as a parameter of the build script.
* Work around build's cleanup failure when removal of an already deleted folder is attempted.
* Exclude bundling fallbacks with `darwin-arm64` since Node.js v14 has no releases for them.
* Update tests to accommodate `darwin-arm64`.
* Generalize the Node.js versions used in some tests.

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 89dc051)
@AMoo-Miki AMoo-Miki mentioned this pull request Nov 13, 2023
Merged
AMoo-Miki added a commit that referenced this pull request Nov 13, 2023
@AMoo-Miki
[Manual backport] Enhance darwin-arm64 release (#5455) (#5469)
2cbe33c 
* Enhance darwin-arm64 release (#5455)

* Add min-builds for `darwin-x64` and `darwin-arm64`.
* Expose `--darwin-arm` as a parameter of the build script.
* Work around build's cleanup failure when removal of an already deleted folder is attempted.
* Exclude bundling fallbacks with `darwin-arm64` since Node.js v14 has no releases for them.
* Update tests to accommodate `darwin-arm64`.
* Generalize the Node.js versions used in some tests.

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 89dc051)

* Update CHANGELOG for darwin-arm64

Signed-off-by: Miki <miki@amazon.com>

---------

Signed-off-by: Miki <miki@amazon.com>
@bayandin bayandin mentioned this pull request Jun 24, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyan-amazon zengyan-amazon zengyan-amazon approved these changes

@ananzh ananzh ananzh approved these changes

@manasvinibs manasvinibs manasvinibs approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Distribution Build Failed for OpenSearch-Dashboards-3.0.0
4 participants
@AMoo-Miki @zengyan-amazon @ananzh @manasvinibs