-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chromedriver from 107.0.3 to 119.0.1 #5465
Conversation
Replace PR opensearch-project#5454 Signed-off-by: ananzh <ananzh@amazon.com>
303a5c6
to
412a686
Compare
Codecov Report
@@ Coverage Diff @@
## main #5465 +/- ##
=======================================
Coverage 66.96% 66.96%
=======================================
Files 3291 3291
Lines 63243 63243
Branches 10055 10055
=======================================
Hits 42349 42349
Misses 18453 18453
Partials 2441 2441
Flags with carried forward coverage won't be shown. Click here to find out more. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-5465-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 524fd9339d84600e6c351924354e0dade277878e
# Push it to GitHub
git push --set-upstream origin backport/backport-5465-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5465-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 524fd9339d84600e6c351924354e0dade277878e
# Push it to GitHub
git push --set-upstream origin backport/backport-5465-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
) Replace PR opensearch-project#5454 Backport PR opensearch-project#5465 Signed-off-by: ananzh <ananzh@amazon.com>
Backport to 1.3 fail analysis
The specific issue seems to be a SyntaxError in chromedriver/install.js. The line causing the error involves optional chaining (?.), which is a relatively new feature in JavaScript. This optional chaining was introduced in Node.js version 14. Due to this conflict, this chromedriver can't be backported to 1.3. |
Replace PR
#5454
Check List
yarn test:jest
yarn test:jest_integration