Modify data source text for dev tool #5475
Conversation
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
bandinib-amzn
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5475 +/- ##
=======================================
Coverage 66.96% 66.96%
=======================================
Files 3291 3291
Lines 63249 63249
Branches 10057 10057
=======================================
Hits 42355 42355
Misses 18453 18453
Partials 2441 2441
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I think we can skip the changelog. Was there an issue for this? |
| })} | ||
| singleSelection={{ asPlainText: true }} | ||
| options={dataSources} | ||
| selectedOptions={selectedOptions} | ||
| onChange={onChange} | ||
| prepend="DataSource" | ||
| prepend="Data source" |
There was a problem hiding this comment.
A little concern that why did we make the prepend content a constant text instead of wrapping it with i18n? Is Data source a dedicated terms that should not be translated?
There was a problem hiding this comment.
I think this prepend is something else. I couldn't find docs on OUI that made sense to me. @BSFishy do you know what prepend does?
No. There was not an issue. |
ashwin-pc
added
the
Skip-Changelog
Signed-off-by: Bandini Bhopi <bandinib@amazon.com> (cherry picked from commit 3c9e643) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3c9e643) Signed-off-by: Bandini Bhopi <bandinib@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Modify data source text for dev tool based on UX input.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration