[OSCI][Fix][Discover]Prevent Adding Timefield to the Side Nav Selected Fields on Column Removal

[MadaniKK]

Description

Issue #5527: Now the time field of an index pattern would not get wrongly added to the selected field when we click remove column on canvas.

Issue #5538: When doc_table:hideTimeColumn is enabled, removing the last columns from the canvas would automatically add "_source" to the selected fields in the left nav bar.

Issues Resolved

issue #5527 #5538

Screenshot

For #5527

For #5538

Testing the changes

Check List

• [x ] All tests pass
  • [x ] yarn test:jest
  • [ x] yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• [ x] Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5c45a3) 66.98% compared to head (c1a322e) 67.02%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5537      +/-   ##
==========================================
+ Coverage   66.98%   67.02%   +0.03%     
==========================================
  Files        3294     3294              
  Lines       63296    63296              
  Branches    10066    10066              
==========================================
+ Hits        42398    42422      +24     
+ Misses      18500    18431      -69     
- Partials     2398     2443      +45     

Flag	Coverage Δ
Linux_1	35.24% <ø> (ø)
Linux_2	55.17% <ø> (?)
Linux_3	43.87% <ø> (?)
Linux_4	35.34% <ø> (ø)
Windows_1	35.27% <ø> (ø)
Windows_2	55.14% <ø> (ø)
Windows_3	43.89% <ø> (ø)
Windows_4	35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshuarrrr]

@MadaniKK Can you add a changelog entry?

[MadaniKK]

@MadaniKK Can you add a changelog entry?

Hi, Josh, I found another bug (issue #5538) when I wrote this PR, and I found out I could fix it within the same PR. should I make a new PR or fix these two issues in the same PR? ( I just needed to reorder two lines of codes that I wrote in this PR and it will fix issue #5538 too)

[ananzh]

@MadaniKK love these fixes and thanks a lot. I will re-run the failed cypress tests and update you.

[ananzh]

@MadaniKK, for #5538, your understanding seems not quite right.

This advanced setting doc_table:hideTimeColumn is to allow Discover and Saved Search in Dashboard to not display timestamp column (first column) when enabled for a time based index pattern . Without this setting, for time based index pattern, display timestamp column is default and user can't remove it.

For the legacy Discover, we could have a better understanding

• after enabling doc_table:hideTimeColumn

The buildColumns fun itself will make sure when no columns return ['_source']:

export function buildColumns(columns: string[]) {
  if (columns.length > 1 && columns.indexOf('_source') !== -1) {
    return columns.filter((col) => col !== '_source');
  } else if (columns.length !== 0) {
    return columns;
  }
  return ['_source'];
}

Therefore, the problem is why enabling doc_table:hideTimeColumn will cause #5538 and how could fix it. I think we haven't implement the logic for this advanced settings.

[ananzh]

@MadaniKK I would suggest targeting #5527 in this PR and re-check if all logics are needed if just fixing this specific issue.

Then start another PR to make sure we have time field removed when enabling doc_table:hideTimeColumn. What do you think?

[ananzh]

Would like to research on doc_table:hideTimeColumn and find out the root cause of the break. Thanks a lot for carefully checking these settings.

[ananzh]

I think this is an acceptable change to fix all the bugs together. @MadaniKK could you select and add more explains here from public slack? Also there is a conflict on CHANGELOG. Thanks.