Custom Branding: Relative URL should be allowed #5572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alankarsharma
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq and
bandinib-amzn
as code owners
Alankarsharma
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5572 +/- ##
==========================================
- Coverage 66.98% 66.98% -0.01%
==========================================
Files 3293 3293
Lines 63294 63296 +2
Branches 10067 10068 +1
==========================================
Hits 42396 42396
- Misses 18458 18459 +1
- Partials 2440 2441 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hello @Alankarsharma, thanks for opening! Could you please sign the commit? https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#developer-certificate-of-origin. I merged the branch with |
|
cc: @abbyhu2000 can you check this out? |
Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com>
…t#5579) Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 39fdcad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com>
…opensearch-project#5577) * [BUG][Data] Support for custom filters with heterogeneous data fields When enabling the advanced setting `courier:ignoreFilterIfFieldNotInIndex` Custom OpenSearch Query DSL filters could technically be applied to index patterns that map to indices that are not exactly the same. Since the custom query filter is a user input then users can really type anything that they need. Or any field that they know is present but we do not know for sure. Therefore, we can check if the id which is the index pattern title to check if we should apply the filter or not. Issue resolved: https://github.com/opensearch-project/dashboards-visualizations/issues/281 I believe issue: opensearch-project#5423 Should closed as that is expected functionality. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Cleanup] utilize the same helper function Originally when implementing the fix the historical comment caused concern about potential breaking changes. But after discussion, we decided it is more clear to consolidate the helper functions. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com>
Fixed it, added test case for this as well. Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com>
Alankarsharma
force-pushed
the
patch-1
branch
from
856e434
to
2f1b887
Compare
abbyhu2000
reviewed
Dec 13, 2023
| @@ -171,7 +171,7 @@ export class RenderingService { | |||
| }; | |||
| } | |||
|
|
|||
| public async stop() {} | |||
| public async stop() { } | |||
There was a problem hiding this comment.
Could you delete the empty space here? it causes a linter error @Alankarsharma
There was a problem hiding this comment.
done, thanks for the review
|
Just a linter error, otherwise LGTM! |
Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com>
|
@Alankarsharma Could you please also add the change in the Changelog.md? |
Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com>
Done |
SuZhou-Joe
approved these changes
Dec 15, 2023
ananzh
approved these changes
Dec 15, 2023
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Dec 15, 2023
When enabling the advanced setting `courier:ignoreFilterIfFieldNotInIndex` Custom OpenSearch Query DSL filters could technically be applied to index patterns that map to indices that are not exactly the same. Since the custom query filter is a user input then users can really type anything that they need. Or any field that they know is present but we do not know for sure. Therefore, we can check if the id which is the index pattern title to check if we should apply the filter or not. Issue resolved: https://github.com/opensearch-project/dashboards-visualizations/issues/281 Issue could be closed: #5423 --------- Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit d8cbc17) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
added a commit
that referenced
this pull request
Dec 19, 2023
When enabling the advanced setting `courier:ignoreFilterIfFieldNotInIndex` Custom OpenSearch Query DSL filters could technically be applied to index patterns that map to indices that are not exactly the same. Since the custom query filter is a user input then users can really type anything that they need. Or any field that they know is present but we do not know for sure. Therefore, we can check if the id which is the index pattern title to check if we should apply the filter or not. Issue resolved: https://github.com/opensearch-project/dashboards-visualizations/issues/281 Issue could be closed: #5423 --------- (cherry picked from commit d8cbc17) Signed-off-by: Alankarsharma <alankar.sharma005@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have open search running behind a reverse proxy along with other service (Logo is deployed here). From OpenSearch server external URLs are not accessible so if we give this value then Dashboard on startup are not able to fetch the logo and revert to original, if we enter internal URL then server starts properly but logo are not loaded as internal URL is not accessible from external network.
Here if relative URL is passed returning true so that server can start properly and logos are also loaded properly in browser.
Workaround like hostname mapping work only if both internal and external service are deployed on HTTP or HTTPS, but in case of SSL offloading this also fails.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration