Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer] Adding PPL to query language selector #5623
[Data Explorer] Adding PPL to query language selector #5623
Changes from all commits
217f7b9
ad77712
75bff8d
f3b4c45
f01be2d
6723808
35212a4
0b5b098
257a9bf
d8d2e5c
5bf8243
e590676
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This subscribe should be wrapped inside a useEffect I suppose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Check warning on line 66 in src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Codecov / codecov/patch
src/plugins/data/public/ui/query_string_input/language_switcher.tsx#L65-L66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need SQL. Also can we use the internationalized version of these labels from below? i.e.
luceneLabel
anddqlLabel
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added SQL which will also redirect to observability page.
dataExplorerOptions
is used by<EuiComboBox>
to show the dropdown list. Do we want to change how the label is shown on the dropdown fromlucene
toluceneLabel
etc? It looks kinda crowded to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no, i meant that on line 90 you have an internationalized version of these labels. Can we reuse them? and add new labels for the missing languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an enum for these language options like
? And I suggest adding an id field inside options though under context of language, label no need to wrapped by i18n.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will still need i18n since its purpose is to individually identify the language name. e.g.
data.query.queryBar.dqlLanguageName
Check warning on line 116 in src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Codecov / codecov/patch
src/plugins/data/public/ui/query_string_input/language_switcher.tsx#L115-L116
Check warning on line 119 in src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Codecov / codecov/patch
src/plugins/data/public/ui/query_string_input/language_switcher.tsx#L119
Check warning on line 125 in src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Codecov / codecov/patch
src/plugins/data/public/ui/query_string_input/language_switcher.tsx#L125
Check warning on line 128 in src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Codecov / codecov/patch
src/plugins/data/public/ui/query_string_input/language_switcher.tsx#L128
Check warning on line 149 in src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Codecov / codecov/patch
src/plugins/data/public/ui/query_string_input/language_switcher.tsx#L149
Check warning on line 194 in src/plugins/data/public/ui/query_string_input/language_switcher.tsx
Codecov / codecov/patch
src/plugins/data/public/ui/query_string_input/language_switcher.tsx#L194