[Data Explorer] Fix missing field error from taking down the page #5626

ashwin-pc · 2023-12-18T20:51:40Z

Description

If an index pattern is created programatically using saved object API but a corresponding index does not exist for the pattern, discover throws a full page error that blocks the app from being used. This change still displays the error but allows the user to continue using the app to make other changes and remedy the situation.

Issues Resolved

closes #5625

Screenshot

Before:

After:

Testing the changes

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

codecov · 2023-12-18T21:07:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d57b8a) 67.02% compared to head (460ab95) 66.97%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5626      +/-   ##
==========================================
- Coverage   67.02%   66.97%   -0.05%     
==========================================
  Files        3294     3294              
  Lines       63296    63298       +2     
  Branches    10066    10067       +1     
==========================================
- Hits        42422    42395      -27     
- Misses      18434    18437       +3     
- Partials     2440     2466      +26

Flag	Coverage Δ
Linux_1	`35.24% <ø> (ø)`
Linux_2	`?`
Linux_3	`?`
Linux_4	`?`
Windows_1	`35.27% <ø> (ø)`
Windows_2	`55.14% <ø> (+<0.01%)`	⬆️
Windows_3	`43.89% <ø> (-0.01%)`	⬇️
Windows_4	`35.34% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

CHANGELOG.md

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

SuZhou-Joe · 2023-12-19T01:25:06Z

src/plugins/discover/public/application/components/chart/utils/create_histogram_configs.ts

+  try {
+    return data.search.aggs.createAggConfigs(indexPattern, visStateAggs);
+  } catch (error) {
+    // Just display the error to the user but continue to render the rest of the page
+    data.search.showError(error as Error);
+    return;
+  }


A test to cover this section is preferred.

) * Handle missing fields error Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * adds changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * ndo unnecessary changes to changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * cleanup changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fix PR number Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 28c1fbb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

) (#5747) * Handle missing fields error --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 28c1fbb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

) * Handle missing fields error Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * adds changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * ndo unnecessary changes to changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * cleanup changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fix PR number Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 28c1fbb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

) (#5748) * Handle missing fields error Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * adds changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * ndo unnecessary changes to changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * cleanup changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fix PR number Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 28c1fbb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

) (#5828) * Handle missing fields error --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 28c1fbb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Handle missing fields error

a3d8610

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc requested review from ananzh, kavilla, AMoo-Miki, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy, curq, bandinib-amzn and SuZhou-Joe as code owners December 18, 2023 20:51

github-actions bot added the distinguished-contributor label Dec 18, 2023

manasvinibs previously approved these changes Dec 18, 2023

View reviewed changes

adds changelog

5b53e37

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc dismissed manasvinibs’s stale review via 5b53e37 December 18, 2023 21:36

ashwin-pc added 2 commits December 18, 2023 21:37

ndo unnecessary changes to changelog

e21f13d

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

cleanup changelog

e7e24a8

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

AMoo-Miki previously approved these changes Dec 18, 2023

View reviewed changes

manasvinibs reviewed Dec 18, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Fix PR number

460ab95

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc dismissed AMoo-Miki’s stale review via 460ab95 December 19, 2023 00:08

SuZhou-Joe reviewed Dec 19, 2023

View reviewed changes

SuZhou-Joe approved these changes Dec 19, 2023

View reviewed changes

Flyingliuhub approved these changes Dec 19, 2023

View reviewed changes

ZilongX approved these changes Dec 19, 2023

View reviewed changes

ashwin-pc merged commit 28c1fbb into opensearch-project:main Dec 19, 2023
67 checks passed

ananzh added discover for discover reinvent bug Something isn't working backport 2.11 backport 2.x labels Jan 26, 2024

opensearch-trigger-bot bot mentioned this pull request Jan 26, 2024

[Backport 2.11] [Data Explorer] Fix missing field error from taking down the page #5747

Merged

opensearch-trigger-bot bot mentioned this pull request Jan 26, 2024

[Backport 2.x] [Data Explorer] Fix missing field error from taking down the page #5748

Merged

ashwin-pc added the backport 2.12 label Feb 7, 2024

opensearch-trigger-bot bot mentioned this pull request Feb 7, 2024

[Backport 2.12] [Data Explorer] Fix missing field error from taking down the page #5828

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data Explorer] Fix missing field error from taking down the page #5626

[Data Explorer] Fix missing field error from taking down the page #5626

ashwin-pc commented Dec 18, 2023

codecov bot commented Dec 18, 2023 •

edited

Loading

SuZhou-Joe Dec 19, 2023

[Data Explorer] Fix missing field error from taking down the page #5626

[Data Explorer] Fix missing field error from taking down the page #5626

Conversation

ashwin-pc commented Dec 18, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov bot commented Dec 18, 2023 • edited Loading

Codecov Report

SuZhou-Joe Dec 19, 2023

Choose a reason for hiding this comment

codecov bot commented Dec 18, 2023 •

edited

Loading