Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b2… #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…47 appears twice on line 273 and 404. Duplicate entry. Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
zhyuanqi
force-pushed
the
zhyuanqi-dev-1
branch
from
b285eff
to
e6a8d79
Compare
1 task
|
Previous pull request: #5591 |
ZilongX
previously approved these changes
Jan 8, 2024
6 tasks
Signed-off-by: Yuanqi(Ella) Zhu <53279298+zhyuanqi@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5668 +/- ##
=======================================
Coverage 67.02% 67.02%
=======================================
Files 3294 3294
Lines 63307 63307
Branches 10071 10071
=======================================
Hits 42430 42430
Misses 18431 18431
Partials 2446 2446
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jan 9, 2024
manasvinibs
approved these changes
Jan 9, 2024
bandinib-amzn
approved these changes
Jan 9, 2024
Flyingliuhub
approved these changes
Jan 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
#5668) * Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry. Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Signed-off-by: Yuanqi(Ella) Zhu <53279298+zhyuanqi@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 09b64a4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 10, 2024
#5668) (#5676) * Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry. Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Signed-off-by: Yuanqi(Ella) Zhu <53279298+zhyuanqi@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 09b64a4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this pull request
Feb 5, 2024
opensearch-project#5668) * Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry. Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Signed-off-by: Yuanqi(Ella) Zhu <53279298+zhyuanqi@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry.
Issues Resolved
No related issue with it.
Testing the changes
Since we only delete old record of id 90943e30-9a47-11e8-b64d-95841ca0b247. No record still exists on line 404. Visualization stays the same
Check List
yarn test:jest(Two tests failed in my local. log_rotator.test.ts and create_os_package_tasks.test.ts. I don't think they are related to my change though)yarn test:jest_integration