Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getClient and getLegacyClient to use authentication method registry #5881

Merged
merged 2 commits into from
Feb 23, 2024

Adds changelog and UT

d0b1d2b
Select commit
Loading
Failed to load commit list.
Merged

Refactor getClient and getLegacyClient to use authentication method registry #5881

Adds changelog and UT
d0b1d2b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 23, 2024 in 1s

67.00% (-0.01%) compared to 4ab0ca8

View this Pull Request on Codecov

67.00% (-0.01%) compared to 4ab0ca8

Details

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.00%. Comparing base (4ab0ca8) to head (d0b1d2b).

Files Patch % Lines
...gins/data_source/server/client/configure_client.ts 85.71% 0 Missing and 2 partials ⚠️
...ta_source/server/legacy/configure_legacy_client.ts 91.66% 0 Missing and 1 partial ⚠️
...ins/data_source/server/util/credential_provider.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5881      +/-   ##
==========================================
- Coverage   67.01%   67.00%   -0.01%     
==========================================
  Files        3305     3307       +2     
  Lines       63585    63614      +29     
  Branches    10155    10163       +8     
==========================================
+ Hits        42611    42627      +16     
- Misses      18505    18518      +13     
  Partials     2469     2469

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov