Rename kbn-optimizer to osd-optimizer (#37) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
86 tasks
mihirsoni
reviewed
Mar 4, 2021
| @@ -42,8 +42,7 @@ export function logOptimizerState(log: ToolingLog, config: OptimizerConfig) { | |||
|
|
|||
| if (event?.type === 'bundle not cached') { | |||
| log.debug( | |||
| `[${event.bundle.id}] bundle not cached because [${event.reason}]${ | |||
| event.diff ? `, diff:\n${event.diff}` : '' | |||
| `[${event.bundle.id}] bundle not cached because [${event.reason}]${event.diff ? `, diff:\n${event.diff}` : '' | |||
There was a problem hiding this comment.
is this change needed? looks like formatting change, i would avoid any other changes just to get clean diff.
There was a problem hiding this comment.
This happens automatically by eslint on save.
mihirsoni
reviewed
Mar 4, 2021
| }, | ||
| "include": [ | ||
| "index.d.ts", | ||
| "src/**/*" | ||
| ] | ||
| } | ||
| } |
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor boktorbb@amazon.com