[Discover] Fixes safari overflow bug #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
ashwin-pc
requested review from
ananzh,
kavilla,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5948 +/- ##
=======================================
Coverage 67.00% 67.00%
=======================================
Files 3307 3307
Lines 63614 63614
Branches 10163 10163
=======================================
+ Hits 42625 42627 +2
+ Misses 18519 18518 -1
+ Partials 2470 2469 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
could we share the screenshoot before and after to help review the PR |
ananzh
previously approved these changes
Feb 26, 2024
|
@seraphjiang I did not add a screenshot here since the issue linked has an image of what the bug looks like and the fix basically get rid of the bug. There is no visual change to the UI because of this PR. I can add it if it helps though |
AMoo-Miki
reviewed
Feb 26, 2024
Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
previously approved these changes
Feb 26, 2024
AMoo-Miki
previously approved these changes
Feb 26, 2024
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
approved these changes
Feb 26, 2024
AMoo-Miki
approved these changes
Feb 27, 2024
|
@seraphjiang before the fix, in Safari 17 it looks like this (2.11 test domain) After this, just normal display. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit c1439d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Feb 27, 2024
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
abbyhu2000
added a commit
that referenced
this pull request
Mar 1, 2024
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit c1439d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 4, 2024
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
SuZhou-Joe
pushed a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The translate prop on the source cell causes a glitch in Safari that causes the overflow property to not work as expected in some scenarios. Removing it fixes the issue.
Issues Resolved
fixes #5941
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration