Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] remove incorrect reference in testing.md #597

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 8, 2021

Signed-off-by: Anan Zhuang ananzh@amazon.com

Description

Remove incorrect reference in testing.md

Partially Resolved

#592

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added bug Something isn't working v1.0.0 labels Jul 8, 2021
@ananzh ananzh requested review from tmarkley, ahopp and kavilla July 8, 2021 18:17
@ananzh ananzh self-assigned this Jul 8, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 13bea01

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: git stuff mentioned

but I think the empty TODO should be removed.

src/core/TESTING.md Show resolved Hide resolved
@ananzh ananzh force-pushed the fix_testing_doc branch from 13bea01 to 00b3a7a Compare July 8, 2021 18:43
There is a kibana closed issue reference under test
"authenticated / non-authenticated user access".
We removed the reference in this PR.

Partially Resolved:
opensearch-project#592

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh force-pushed the fix_testing_doc branch from 00b3a7a to 965ac9e Compare July 8, 2021 18:44
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 965ac9e

Copy link
Member Author

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kavilla I removed the whole todo concept and amend the commit. pls take another look.

src/core/TESTING.md Show resolved Hide resolved
@kavilla kavilla self-requested a review July 9, 2021 05:31
@ananzh ananzh requested a review from seraphjiang July 9, 2021 17:54
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@mihirsoni mihirsoni merged commit f362dab into opensearch-project:main Jul 9, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
There is a kibana closed issue reference under test
"authenticated / non-authenticated user access".
We removed the reference in this PR.

Partially Resolved:
opensearch-project#592

Backport PR:
opensearch-project#597

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
There is a kibana closed issue reference under test
"authenticated / non-authenticated user access".
We removed the reference in this PR.

Partially Resolved:
opensearch-project#592

Backport PR:
opensearch-project#597

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 11, 2021
There is a kibana closed issue reference under test
"authenticated / non-authenticated user access".
We removed the reference in this PR.

Partially Resolved:
#592

Backport PR:
#597

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 11, 2021
There is a kibana closed issue reference under test
"authenticated / non-authenticated user access".
We removed the reference in this PR.

Partially Resolved:
#592

Backport PR:
#597

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 12, 2021
…arch-project#608)

/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#597

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 12, 2021
…arch-project#608)

/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#597

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh deleted the fix_testing_doc branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants