-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] remove incorrect reference in testing.md #597
Conversation
✅ DCO Check Passed 13bea01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: git stuff mentioned
but I think the empty TODO should be removed.
There is a kibana closed issue reference under test "authenticated / non-authenticated user access". We removed the reference in this PR. Partially Resolved: opensearch-project#592 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
✅ DCO Check Passed 965ac9e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kavilla I removed the whole todo concept and amend the commit. pls take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
There is a kibana closed issue reference under test "authenticated / non-authenticated user access". We removed the reference in this PR. Partially Resolved: opensearch-project#592 Backport PR: opensearch-project#597 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
There is a kibana closed issue reference under test "authenticated / non-authenticated user access". We removed the reference in this PR. Partially Resolved: opensearch-project#592 Backport PR: opensearch-project#597 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
…arch-project#608) /packages/osd-optimizer/README.md has a kibana issue reference. This PR replaces the kibana issue with an open discuss issue. Partically Resolved: opensearch-project#592 Backport PR: opensearch-project#597 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
…arch-project#608) /packages/osd-optimizer/README.md has a kibana issue reference. This PR replaces the kibana issue with an open discuss issue. Partically Resolved: opensearch-project#592 Backport PR: opensearch-project#597 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Anan Zhuang ananzh@amazon.com
Description
Remove incorrect reference in testing.md
Partially Resolved
#592
Check List