[Backport 2.x] Hide/Show authentication method in multi data source plugin based on configuration #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…configuration (#5916) * [AuthType Config] Add EnabledAuthType configuration in yml file and pass value to dataSourceManagement root mount Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthType Config] provide default auth types when types array is empty Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard - DataSourceCreationForm] Integrate auth cofig with AuthRegistray and providing data source options from AuthRegistry Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard] Support default selected auth type in datasource creation page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard] SDisable auth option selector when auth options no more than 1 Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard] clear credential attribute every time use select NoAuth option. Also update credentialField data type Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update yml file to disable config Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update change.md file Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Fix broken test cases Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add more unit tests Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] update unit test and handle scenario when no options enabled Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] update description of unit test case Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] update unit test cases to resolve comment Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Snapshot auth option super selector for unit test. Also upate the default message in datasorurce creation form ---> auth type section Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com> (cherry picked from commit 20b6c5a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5976 +/- ##
==========================================
+ Coverage 67.06% 67.08% +0.02%
==========================================
Files 3308 3308
Lines 63690 63727 +37
Branches 10160 10168 +8
==========================================
+ Hits 42714 42753 +39
+ Misses 18511 18507 -4
- Partials 2465 2467 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bandinib-amzn
approved these changes
Feb 28, 2024
ZilongX
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 20b6c5a from #5916.