Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing incorrect CONTRIBUTING.md language and adding updated links #598

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Removing incorrect CONTRIBUTING.md language and adding updated links #598

merged 1 commit into from
Jul 23, 2021

Conversation

ahopp
Copy link
Contributor

@ahopp ahopp commented Jul 8, 2021 •
edited by tmarkley
Loading

Description

  • Move ToC to top to match the OpenSearch repo
  • Minor formatting changes
  • Remove reference to pre-alpha state
  • Add links for opening issues
  • Remove "w00t!!!" from end of file

Issues Resolved

Partially Resolve: Issue #592

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 8314d25
Run ./dev-tools/signoff-check.sh remotes/origin/main 8314d2566b242a416c1d0b4e8ad99a2c42e2989b to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@kavilla kavilla self-requested a review July 8, 2021 18:25
kavilla
kavilla requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. However, the commit needs to be signed https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#developer-certificate-of-origin.

Also, do we think this will be the only 'Update CONTRIBUTING.md' before GA, if so I'm fine with the commit message. But might be nice to reference the git issue in the description for anyone using any tools.

@ahopp ahopp changed the title Update CONTRIBUTING.md Removing incorrect CONTRIBUTING.md language and adding updated links Jul 8, 2021
@ahopp
Copy link
Contributor Author

ahopp commented Jul 8, 2021

Thanks for this. However, the commit needs to be signed https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#developer-certificate-of-origin.

Thanks, added.

Also, do we think this will be the only 'Update CONTRIBUTING.md' before GA, if so I'm fine with the commit message. But might be nice to reference the git issue in the description for anyone using any tools.

I don't see any major changes but I've updated with a more descriptive title. Thanks!

@ananzh ananzh mentioned this pull request Jul 8, 2021
Closed
30 tasks
Update CONTRIBUTING.md
198f676 
* Move ToC to top to match the OpenSearch repo
* Minor formatting changes
* Remove reference to pre-alpha state
* Add links for opening issues
* Remove "w00t!!!" from end of file

Signed-off-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley requested review from kavilla, ananzh and boktorbb July 22, 2021 22:26
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 198f676

boktorbb
boktorbb approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mihirsoni
mihirsoni approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@tmarkley tmarkley merged commit d4e28c8 into main Jul 23, 2021
@tmarkley tmarkley deleted the ahopp-patch-1 branch July 23, 2021 17:41
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Jul 23, 2021
@ahopp
Update CONTRIBUTING.md (opensearch-project#598)
1ebd8f5 
* Move ToC to top to match the OpenSearch repo
* Minor formatting changes
* Remove reference to pre-alpha state
* Add links for opening issues
* Remove "w00t!!!" from end of file

Signed-off-by: Tommy Markley <markleyt@amazon.com>

Co-authored-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley mentioned this pull request Jul 23, 2021
Merged
1 task
tmarkley pushed a commit that referenced this pull request Jul 26, 2021
@ahopp
Update CONTRIBUTING.md (#598) (#663)
9645bcd 
* Move ToC to top to match the OpenSearch repo
* Minor formatting changes
* Remove reference to pre-alpha state
* Add links for opening issues
* Remove "w00t!!!" from end of file

Signed-off-by: Tommy Markley <markleyt@amazon.com>

Co-authored-by: Tommy Markley <markleyt@amazon.com>

Co-authored-by: Andrew Hopp <andrew.hopp@me.com>
@tmarkley tmarkley added the docs Improvements or additions to documentation label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boktorbb boktorbb boktorbb approved these changes

@kavilla kavilla kavilla approved these changes

@mihirsoni mihirsoni mihirsoni approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

Assignees
No one assigned
Labels
docs Improvements or additions to documentation v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ahopp @opensearch-ci-bot @mihirsoni @kavilla @boktorbb @tmarkley