-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD]Fix schema for test connection to separate validation based on auth type #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
March 1, 2024 19:37
bandinib-amzn
previously approved these changes
Mar 1, 2024
bandinib-amzn
added
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
backport 2.x
multiple datasource
multiple datasource project
v2.13.0
and removed
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
labels
Mar 1, 2024
First I thought we can skip ChangeLog. But it is bug fix, so we should add in ChangeLog, right? @BionIT What do you think? |
BionIT
changed the title
Fix schema for test connection to separate validation based on auth type
[MD]Fix schema for test connection to separate validation based on auth type
Mar 1, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
Yeah, I added changelog to unreleased section in a new commit. Thanks @bandinib-amzn! |
bandinib-amzn
approved these changes
Mar 1, 2024
ZilongX
approved these changes
Mar 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
…th type (#5997) * fix schema for test connection Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 0c394bd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 2, 2024
…th type (opensearch-project#5997) * fix schema for test connection Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
Flyingliuhub
pushed a commit
that referenced
this pull request
Mar 3, 2024
…th type (#5997) (#6001) * fix schema for test connection Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 0c394bd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 4, 2024
…th type (opensearch-project#5997) * fix schema for test connection Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change refactors the schema validation for test connection API to separate the validation based on auth type. Tests were added for no auth, sigv4 and basic auth.
Issues Resolved
Fixes #5987
Screenshot
fixschema.mp4
Testing the changes
The following steps were performed:
Check List
yarn test:jest
yarn test:jest_integration