-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi Data Source] Render credential form registered from AuthMethod #6002
[Multi Data Source] Render credential form registered from AuthMethod #6002
Conversation
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
…create datasource page Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
src/plugins/data_source_management/public/auth_registry/authentication_methods_registry.ts
Outdated
Show resolved
Hide resolved
...blic/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
Show resolved
Hide resolved
...blic/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
Show resolved
Hide resolved
...management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
Show resolved
Hide resolved
In #5987, we found a bug caused by test connection API schema would fail input validation due to missing credentials for no authentication method, I refactored the schema validation to validate based on auth tyep, then wonder for custom authentication type, how does test connection work now, can you add recording for the test connection before data source creation? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6002 +/- ##
==========================================
- Coverage 67.11% 67.10% -0.02%
==========================================
Files 3315 3315
Lines 63904 63922 +18
Branches 10220 10220
==========================================
Hits 42892 42892
- Misses 18528 18544 +16
- Partials 2484 2486 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the comment. |
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
...components/create_data_source_wizard/components/create_form/create_data_source_form.test.tsx
Outdated
Show resolved
Hide resolved
...components/create_data_source_wizard/components/create_form/create_data_source_form.test.tsx
Outdated
Show resolved
Hide resolved
...components/create_data_source_wizard/components/create_form/create_data_source_form.test.tsx
Show resolved
Hide resolved
…ered Auth type scenario Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
…#6002) * [TokenExchange] Render credential form registered from AuthMethod Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add unittest to test registered credential form get rendered in create datasource page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Update test case descriptions Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [Token Exchange] improve code format in create datasource page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add unit test for edit datasource page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update changelog file Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * update yml config file to original status Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Resolving comments Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add more unit test to cover existing auth type and plugin registered Auth type scenario Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Resolving comments, update pmport path Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com> (cherry picked from commit 5ef10da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…#6002) (#6024) * [TokenExchange] Render credential form registered from AuthMethod Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add unittest to test registered credential form get rendered in create datasource page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Update test case descriptions Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [Token Exchange] improve code format in create datasource page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add unit test for edit datasource page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update changelog file Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * update yml config file to original status Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Resolving comments Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add more unit test to cover existing auth type and plugin registered Auth type scenario Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Resolving comments, update pmport path Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com> (cherry picked from commit 5ef10da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Partial of Refactoring create and edit form to use authentication registry user story.
Issues Resolved
Partially fixes #5692, #5838
Screenshot
CredentialForm.mov
Testing the changes
Test cases added
Check List
yarn test:jest
yarn test:jest_integration