Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove license concepts in packages/osd-opensearch #602

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 8, 2021

Description

Currenlty, /packages/osd-opensearch/README.md still have license concepts. This PR cleans the concepts.

Partially Resolved:

#592

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added bug Something isn't working v1.0.0 labels Jul 8, 2021
@ananzh ananzh requested review from tmarkley, ahopp and kavilla July 8, 2021 20:26
@ananzh ananzh self-assigned this Jul 8, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d4a925b

kavilla
kavilla previously approved these changes Jul 8, 2021
@ananzh ananzh requested a review from seraphjiang July 9, 2021 17:54
Currenlty, /packages/osd-opensearch/README.md still have license
concepts. This PR cleans the concepts.

Partially Resolved:
opensearch-project#592

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 418978d

@ananzh ananzh changed the title [Bug] Replace trial/basic license to oss [Bug] Remove license concepts in packages/osd-opensearch Jul 9, 2021
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!
Thanks for changes, I think we should have issue to piggy back on this later. I am unsure if this working at all.

@ananzh
Copy link
Member Author

ananzh commented Jul 9, 2021

LGTM !!
Thanks for changes, I think we should have issue to piggy back on this later. I am unsure if this working at all.

Thanks @mihirsoni I will create an issue to double check whether snapshot cmd working

@ananzh
Copy link
Member Author

ananzh commented Jul 9, 2021

Follow up issue: #619

@ananzh ananzh merged commit 462db5a into opensearch-project:main Jul 9, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
Currenlty, /packages/osd-opensearch/README.md still have license
concepts. This PR cleans the concepts.

Partially Resolved:
opensearch-project#592

Backport PR:
opensearch-project#602

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
Currenlty, /packages/osd-opensearch/README.md still have license
concepts. This PR cleans the concepts.

Partially Resolved:
opensearch-project#592

Backport PR:
opensearch-project#602

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 10, 2021
Currenlty, /packages/osd-opensearch/README.md still have license
concepts. This PR cleans the concepts.

Partially Resolved:
#592

Backport PR:
#602

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 10, 2021
Currenlty, /packages/osd-opensearch/README.md still have license
concepts. This PR cleans the concepts.

Partially Resolved:
#592

Backport PR:
#602

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh deleted the fix_license branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants