-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Remove appKey in github-checks-reporter #603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
changed the title
[Bug] Remove appKay in github-checks-reporter
[Bug] Remove appKey in github-checks-reporter
Jul 8, 2021
github-checks-reporter is a task wrapper that provides expressive CI feedback via GitHub checks. Currently, we don’t have our own appKey. To avoid any confusions, this PR removed the old key. Partically Resolved: opensearch-project#592 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
fix_checks_reporter
branch
from
July 8, 2021 20:37
00abbfc
to
fe21fb4
Compare
30 tasks
❌ DCO Check Failed 00abbfc |
✅ DCO Check Passed fe21fb4 |
kavilla
approved these changes
Jul 8, 2021
mihirsoni
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Thanks for the changes.
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jul 9, 2021
github-checks-reporter is a task wrapper that provides expressive CI feedback via GitHub checks. Currently, we don’t have our own appKey. To avoid any confusions, this PR removed the old key. Partically Resolved: opensearch-project#592 Backport PR: opensearch-project#603 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jul 9, 2021
github-checks-reporter is a task wrapper that provides expressive CI feedback via GitHub checks. Currently, we don’t have our own appKey. To avoid any confusions, this PR removed the old key. Partically Resolved: opensearch-project#592 Backport PR: opensearch-project#603 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
This was referenced Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
github-checks-reporter is a task wrapper that provides expressive
CI feedback via GitHub checks. Currently, we don’t have our own
appKey. To avoid any confusions, this PR removed the old key.
Partically Resolved:
#592
Signed-off-by: Anan Zhuang ananzh@amazon.com
Check List