Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] Change cluster selector component name to data source selector #6042

Merged
merged 3 commits into from
Mar 6, 2024
Merged

[MD] Change cluster selector component name to data source selector #6042

merged 3 commits into from
Mar 6, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Mar 5, 2024

Description

This change renames clusterselector to datasource selector

Issues Resolved

Fixes #6038

Screenshot

rename.mp4

Testing the changes

The following steps were performed in the recording above:

  1. enable data source plugin
  2. add sample data should render data source selector correctly and can select data source and add sample data, and sample data should render correctly
  3. in dev tools, select a data source and perform query should render results correctly
  4. go to query workbench, should render data source selector correctly and can select data source and request to yield indices
  5. go to alert plugin, should render data source selector correctly and can select data source and request to yield monitors from data source

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@BionIT
change component name
777aac4 
Signed-off-by: Lu Yu <nluyu@amazon.com>
@BionIT BionIT changed the title change component name Change cluster selector component to data source selector Mar 5, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.13%. Comparing base (70adcc9) to head (9d2ae45).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6042      +/-   ##
==========================================
- Coverage   67.13%   67.13%   -0.01%     
==========================================
  Files        3318     3318              
  Lines       64021    64021              
  Branches    10256    10256              
==========================================
- Hits        42981    42979       -2     
- Misses      18548    18549       +1     
- Partials     2492     2493       +1
Flag Coverage Δ
Linux_1 31.63% <ø> (ø)
Linux_2 55.20% <ø> (ø)
Linux_3 44.59% <100.00%> (+<0.01%) ⬆️
Linux_4 35.16% <20.00%> (ø)
Windows_1 31.65% <ø> (ø)
Windows_2 55.17% <ø> (ø)
Windows_3 44.60% <100.00%> (ø)
Windows_4 35.16% <20.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT changed the title Change cluster selector component to data source selector [MD] Change cluster selector component name to data source selector Mar 5, 2024
@BionIT
add change log
48b0573 
Signed-off-by: Lu Yu <nluyu@amazon.com>
@BionIT BionIT added v2.13.0 backport 2.x multiple datasource multiple datasource project labels Mar 6, 2024
seraphjiang
seraphjiang approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@seraphjiang seraphjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@ashwin-pc
Copy link
Member

Isnt Data Connection what we aligned on for the name here? #5790 (comment)

@BionIT
Copy link
Collaborator Author

BionIT commented Mar 6, 2024 •
edited
Loading

Isnt Data Connection what we aligned on for the name here? #5790 (comment)

@ashwin-pc This is the current proposal #6039

@ashwin-pc
Copy link
Member

ashwin-pc commented Mar 6, 2024 •
edited
Loading

That issue was opened 5 hours ago though. Let me take the conversation there. Can we give people time to respond to the proposal?

@seraphjiang
Copy link
Member

That issue was opened 5 hours ago though. Let me take the conversation there. Can we give people time to respond to the proposal?

Thanks @ashwin-pc replied in rfc,

It is expecting to disambious this in 2.13 for developer. It makes sense to give people time for feedback.

Flyingliuhub
Flyingliuhub reviewed Mar 6, 2024
View reviewed changes
...lugins/data_source_management/public/components/cluster_selector/create_cluster_selector.tsx
@@ -1,11 +0,0 @@
/*
Copy link
Member

@Flyingliuhub Flyingliuhub Mar 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to remove folder as well? the folder name still using the cluster_selector?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the folder has been removed

@BionIT BionIT merged commit 8839256 into opensearch-project:main Mar 6, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2024
@github-actions
[MD] Change cluster selector component name to data source selector (#…
8f76829 
…6042)

* change component name

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit 8839256)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 6, 2024
Merged
BionIT pushed a commit that referenced this pull request Mar 7, 2024
@opensearch-trigger-bot @github-actions
[MD] Change cluster selector component name to data source selector (#…
bc99293 
…6042) (#6054)

* change component name



* add change log



---------


(cherry picked from commit 8839256)

Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BionIT BionIT mentioned this pull request Mar 11, 2024
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinruiba xinruiba xinruiba approved these changes

@yujin-emma yujin-emma yujin-emma approved these changes

@ZilongX ZilongX ZilongX approved these changes

@Flyingliuhub Flyingliuhub Flyingliuhub approved these changes

@seraphjiang seraphjiang seraphjiang approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

Assignees
No one assigned
Labels
backport 2.x multiple datasource multiple datasource project v2.13.0 valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MD] Change name of data source picker from cluster selector
7 participants
@BionIT @ashwin-pc @seraphjiang @Flyingliuhub @ZilongX @yujin-emma @xinruiba