Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Clean elastic-eslint-config-kibana in packages/osd-pm/README.md #611

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 9, 2021

Description

Currently, packages/osd-pm/README.md still mentions old package name.
This PR replaces package name from elastic-eslint-config-kibana
to opensearch-eslint-config-opensearch-dashboards. Meanwhile, there
is a duplicate README.md in packages/osd-pm/src which is deleted.

Partically Resolved:

#592

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Currently, packages/osd-pm/README.md still mentions old package name.
This PR replaces package name from elastic-eslint-config-kibana
to opensearch-eslint-config-opensearch-dashboards. Meanwhile, there
is a duplicate README.md in packages/osd-pm/src which is deleted.

Partically Resolved:
opensearch-project#592

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added bug Something isn't working v1.0.0 labels Jul 9, 2021
@ananzh ananzh requested review from tmarkley, ahopp and kavilla July 9, 2021 02:13
@ananzh ananzh self-assigned this Jul 9, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 68c6720

@kavilla kavilla self-requested a review July 9, 2021 17:10
@ananzh ananzh requested review from seraphjiang and mihirsoni July 9, 2021 17:52
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks for the changes.

@mihirsoni mihirsoni merged commit 61c1ad5 into opensearch-project:main Jul 9, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
Currently, packages/osd-pm/README.md still mentions old package name.
This PR replaces package name from elastic-eslint-config-kibana
to opensearch-eslint-config-opensearch-dashboards. Meanwhile, there
is a duplicate README.md in packages/osd-pm/src which is deleted.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#611

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
Currently, packages/osd-pm/README.md still mentions old package name.
This PR replaces package name from elastic-eslint-config-kibana
to opensearch-eslint-config-opensearch-dashboards. Meanwhile, there
is a duplicate README.md in packages/osd-pm/src which is deleted.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#611

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 10, 2021
Currently, packages/osd-pm/README.md still mentions old package name.
This PR replaces package name from elastic-eslint-config-kibana
to opensearch-eslint-config-opensearch-dashboards. Meanwhile, there
is a duplicate README.md in packages/osd-pm/src which is deleted.

Partically Resolved:
#592

Backport PR:
#611

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 10, 2021
Currently, packages/osd-pm/README.md still mentions old package name.
This PR replaces package name from elastic-eslint-config-kibana
to opensearch-eslint-config-opensearch-dashboards. Meanwhile, there
is a duplicate README.md in packages/osd-pm/src which is deleted.

Partically Resolved:
#592

Backport PR:
#611

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh deleted the fix_osd_pm branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants