[Workspace] Add WorkspacePluginSetup interface #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6118 +/- ##
=======================================
Coverage 67.14% 67.14%
=======================================
Files 3326 3326
Lines 64394 64394
Branches 10358 10358
=======================================
Hits 43237 43237
Misses 18627 18627
Partials 2530 2530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
added
the
Skip-Changelog
SuZhou-Joe
reviewed
Mar 12, 2024
| @@ -18,4 +18,4 @@ export const config: PluginConfigDescriptor = { | |||
| schema: configSchema, | |||
| }; | |||
|
|
|||
| export { WorkspaceFindOptions } from './types'; | |||
| export { WorkspaceFindOptions, WorkspacePluginSetup } from './types'; | |||
There was a problem hiding this comment.
Though only Setup is needed, shall we export Start as well to keep the convention?
There was a problem hiding this comment.
sounds good, WorkspacePluginStart added.
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
…oject#6094) * feat: add comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com>
This reverts commit 55f6344. Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
multi_tenacy_check
branch
from
295a37e
to
7e0b2a4
Compare
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
ruanyl and
BionIT
as code owners
ruanyl
approved these changes
Mar 12, 2024
kavilla
approved these changes
Mar 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Add workspacePluginSetup type Signed-off-by: Hailong Cui <ihailong@amazon.com> * add fakenews.co to .lycheeexclude Signed-off-by: Hailong Cui <ihailong@amazon.com> * [Workspace] Add a workspace client in workspace plugin (#6094) * feat: add comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> * Revert "add fakenews.co to .lycheeexclude" This reverts commit 55f6344. Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add WorkspacePluginStart Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 9cdc7c9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Apr 16, 2024
* Add workspacePluginSetup type * add fakenews.co to .lycheeexclude * [Workspace] Add a workspace client in workspace plugin (#6094) * feat: add comment * feat: update unit test * feat: add CHANGELOG * feat: optimize comment * feat: optimize comment * feat: optimize code * feat: optimize code --------- * Revert "add fakenews.co to .lycheeexclude" This reverts commit 55f6344. * Add WorkspacePluginStart --------- (cherry picked from commit 9cdc7c9) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new interface
WorkspacePluginSetup, so that other plugins depends on workspace plugin.Issues Resolved
related to opensearch-project/security-dashboards-plugin#1822
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration