Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @kristenTian to emeritus maintainer #6136

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Flyingliuhub
Copy link
Member

Description

Move @kristenTian to emeritus maintainer

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
@Flyingliuhub
Copy link
Member Author

Flyingliuhub commented Mar 13, 2024

@kristenTian Please let us know if you have any concerns or considerations regarding transitioning to emeritus maintainer status.
cc: @AMoo-Miki @ashwin-pc @seraphjiang @dblock @bbarani

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (df6de4e) to head (d285f54).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6136   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files        3327     3327           
  Lines       64415    64415           
  Branches    10366    10366           
=======================================
  Hits        43262    43262           
  Misses      18621    18621           
  Partials     2532     2532           
Flag Coverage Δ
Linux_1 ?
Linux_2 55.23% <ø> (ø)
Linux_3 44.75% <ø> (ø)
Linux_4 35.06% <ø> (ø)
Windows_1 31.75% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 44.77% <ø> (ø)
Windows_4 35.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit 20efca7 into opensearch-project:main Mar 14, 2024
77 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.x
# Create a new branch
git switch --create backport/backport-6136-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20efca7c3563bb0f5ea05c9a3a13e65285aeaefd
# Push it to GitHub
git push --set-upstream origin backport/backport-6136-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-6136-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6136-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20efca7c3563bb0f5ea05c9a3a13e65285aeaefd
# Push it to GitHub
git push --set-upstream origin backport/backport-6136-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6136-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants