-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cypress config file to its version supported convention #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
manasvinibs
force-pushed
the
cypress-config
branch
from
March 13, 2024 18:51
3be4100
to
708a92f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6137 +/- ##
==========================================
- Coverage 67.16% 67.15% -0.01%
==========================================
Files 3327 3327
Lines 64415 64415
Branches 10366 10366
==========================================
- Hits 43262 43260 -2
- Misses 18621 18622 +1
- Partials 2532 2533 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manasvinibs
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
March 13, 2024 19:30
AMoo-Miki
approved these changes
Mar 14, 2024
ashwin-pc
approved these changes
Mar 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 76c22b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Mar 14, 2024
#6141) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 76c22b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
added a commit
to manasvinibs/OpenSearch-Dashboards
that referenced
this pull request
Mar 15, 2024
manasvinibs
added a commit
that referenced
this pull request
Mar 15, 2024
…to run cypress tests within Dashboards repo and Rename cypress config file to its version supported convention (#6166) * Revert "Rename cypress config file to its version supported convention (#6137) (#6141)" This reverts commit ed2e38d. * Revert "[Tests] Add Github workflow for Test Orchestrator in FT Repo to run cypress tests within Dashboards repo (#5725) (#6095)" This reverts commit 385fce4. Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> --------- Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current cypress version 9.5.4 expects its config file to be in json format.
Issues Resolved
Screenshot
Testing the changes
All tests in CI should pass
Check List
yarn test:jest
yarn test:jest_integration