Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Fix data source filter bug and add tests #6152

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Mar 15, 2024

Description

This change fixes the bug for data source filter, rename the filter function, and added type for the datasource object

Issues Resolved

Fixes #6151

Screenshot

fixbugfilter.mp4

Testing the changes

The following steps were performed in the recording:

  1. enable data source plugin
  2. go to add sample data page, and data source selector renders correctly with all available options
  3. go to dev tools, and data source selector renders correctly with all available options
  4. go to search relevance, and data source selector renders correctly with all available options
  5. add filter function in search relevance remove all data sources, and should show local cluster option only

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lu Yu <nluyu@amazon.com>
@BionIT BionIT changed the title [Multiple Datasource] fix data source filter [Multiple Datasource] Fix data source filter bug and add tests Mar 15, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.18%. Comparing base (31e8481) to head (16d6032).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6152      +/-   ##
==========================================
- Coverage   67.20%   67.18%   -0.02%     
==========================================
  Files        3328     3328              
  Lines       64461    64460       -1     
  Branches    10376    10375       -1     
==========================================
- Hits        43318    43306      -12     
- Misses      18610    18622      +12     
+ Partials     2533     2532       -1     
Flag Coverage Δ
Linux_1 31.74% <ø> (ø)
Linux_2 55.29% <ø> (ø)
Linux_3 44.76% <100.00%> (-0.02%) ⬇️
Linux_4 35.05% <0.00%> (+<0.01%) ⬆️
Windows_1 31.77% <ø> (-0.03%) ⬇️
Windows_2 55.26% <ø> (ø)
Windows_3 44.78% <100.00%> (+<0.01%) ⬆️
Windows_4 35.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu added bug Something isn't working and removed bug Something isn't working labels Mar 15, 2024
@BionIT BionIT merged commit 7e316d1 into opensearch-project:main Mar 15, 2024
81 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2024
* fix data source filter

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit 7e316d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
BionIT pushed a commit that referenced this pull request Mar 15, 2024
#6159)

* fix data source filter

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit 7e316d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The data source selector will render all options if all data sources are filtered out
5 participants