-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple Datasource] Fix data source filter bug and add tests #6152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
March 15, 2024 03:55
BionIT
changed the title
[Multiple Datasource] fix data source filter
[Multiple Datasource] Fix data source filter bug and add tests
Mar 15, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
added
v2.13.0
multiple datasource
multiple datasource project
backport 2.x
labels
Mar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6152 +/- ##
==========================================
- Coverage 67.20% 67.18% -0.02%
==========================================
Files 3328 3328
Lines 64461 64460 -1
Branches 10376 10375 -1
==========================================
- Hits 43318 43306 -12
- Misses 18610 18622 +12
+ Partials 2533 2532 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xinruiba
approved these changes
Mar 15, 2024
ruanyl
approved these changes
Mar 15, 2024
zhongnansu
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Mar 15, 2024
Flyingliuhub
approved these changes
Mar 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
* fix data source filter Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 7e316d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
that referenced
this pull request
Mar 15, 2024
#6159) * fix data source filter Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 7e316d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes the bug for data source filter, rename the filter function, and added type for the datasource object
Issues Resolved
Fixes #6151
Screenshot
fixbugfilter.mp4
Testing the changes
The following steps were performed in the recording:
Check List
yarn test:jest
yarn test:jest_integration