-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple Datasource] Add multi selectable data source component #6211
Conversation
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6211 +/- ##
=======================================
Coverage 67.42% 67.43%
=======================================
Files 3362 3364 +2
Lines 65258 65311 +53
Branches 10524 10534 +10
=======================================
+ Hits 43999 44041 +42
- Misses 18701 18705 +4
- Partials 2558 2565 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
]); | ||
|
||
const input = screen.getByTestId('dataSourceMultiSelectFieldSearch'); | ||
fireEvent.change(input, { target: { value: 'randome input' } }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random
? not randome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Flyingliuhub! Good catch! Fixed typo in new commit!
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6211-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6aa59b246a9b835387eba7a3895b58b9fc7ac74e
# Push it to GitHub
git push --set-upstream origin backport/backport-6211-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…nsearch-project#6211) * add multi selectable data source component Signed-off-by: Lu Yu <nluyu@amazon.com> * update change log Signed-off-by: Lu Yu <nluyu@amazon.com> * add tests Signed-off-by: Lu Yu <nluyu@amazon.com> * add more test Signed-off-by: Lu Yu <nluyu@amazon.com> * refactor to add config Signed-off-by: Lu Yu <nluyu@amazon.com> * fix typo Signed-off-by: Lu Yu <nluyu@amazon.com> * update snapshot Signed-off-by: Lu Yu <nluyu@amazon.com> * add missing interface Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
…) (#6318) * add multi selectable data source component * update change log * add tests * add more test * refactor to add config * fix typo * update snapshot * add missing interface --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
Description
This change adds a new data source component which allows multi selections of data sources.
Issues Resolved
Fixes #6210
Screenshot
multiselect.mp4
Testing the changes
The following steps were performed in the recording above:
deselect all
will deselect all options and the badge icon should show 0Check List
yarn test:jest
yarn test:jest_integration