Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add @xinruiba as a maintainer #6217

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Flyingliuhub
Copy link
Member

Description

Updates MAINTAINERS.md and .github/CODEOWNERS.

Here are xinruiba's current merge contributions, total contributions, and issues:
Successfully merging numerous pull requests (PRs)
Providing valuable reviews for PRs
Addressing and resolving various issues

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (de978d4) to head (2900c03).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6217   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files        3348     3348           
  Lines       64966    64966           
  Branches    10465    10465           
=======================================
  Hits        43729    43729           
  Misses      18690    18690           
  Partials     2547     2547           
Flag Coverage Δ
Linux_1 31.72% <ø> (ø)
Linux_2 55.55% <ø> (ø)
Linux_3 44.68% <ø> (ø)
Linux_4 35.02% <ø> (ø)
Windows_1 31.74% <ø> (ø)
Windows_2 55.52% <ø> (ø)
Windows_3 44.68% <ø> (ø)
Windows_4 35.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flyingliuhub Flyingliuhub merged commit f103b7e into opensearch-project:main Mar 20, 2024
71 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6217-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f103b7ed6c09285a5ff080022c14398c23fe6482
# Push it to GitHub
git push --set-upstream origin backport/backport-6217-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6217-to-2.x.

@Flyingliuhub
Copy link
Member Author

@opensearch-project/admin could you add @xinruiba to a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants