-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Add workspace column to saved objects page #6225
[Workspace] Add workspace column to saved objects page #6225
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6225 +/- ##
==========================================
+ Coverage 67.47% 67.48% +0.01%
==========================================
Files 3368 3370 +2
Lines 65431 65465 +34
Branches 10560 10563 +3
==========================================
+ Hits 44147 44177 +30
- Misses 18713 18716 +3
- Partials 2571 2572 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
97ab814
to
bcea4b4
Compare
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am @ruanyl @xluo-aws @kgcreative @zengyan-amazon Got some questions
|
|
@Hailong-am Did you have a chance to add the feature flag |
...s/saved_objects_management/public/management_section/objects_table/components/table.test.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Flyingliuhub Good suggestion. Did a quick testing for both workspace and data_source enabled case, data source/index pattern associated with workspace display correctly. |
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Thanks for the testing @Hailong-am. Would be good to also test MD scenarios~
Thanks~ |
@xinruiba upload the video about the test steps |
Appreciate, looks good to me~ |
* Add workspace column into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workspaceStart Signed-off-by: Hailong Cui <ihailong@amazon.com> * merge main Signed-off-by: Hailong Cui <ihailong@amazon.com> * add changelog Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 7352365) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* Add workspace column into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workspaceStart Signed-off-by: Hailong Cui <ihailong@amazon.com> * merge main Signed-off-by: Hailong Cui <ihailong@amazon.com> * add changelog Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 7352365) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR will add workspaces column to saved objects page when workspace feature enabled, the workspaces column will show the workspace names which the saved object belongs to.
Issues Resolved
partial of #6098 #4944
Screenshot
Testing the changes
yarn start --workspace.enabled=true
Add existing saved objects to workspace just created
Check List
yarn test:jest
yarn test:jest_integration