Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon in datasource table page to show the default datasource #6231

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

zhyuanqi
Copy link
Collaborator

Description

Add icon in datasource table page to show the default datasource

Issues Resolved

Screenshot

Screen.Recording.2024-03-20.at.6.03.44.PM.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (a2ed39f) to head (219414b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6231      +/-   ##
==========================================
+ Coverage   67.33%   67.35%   +0.02%     
==========================================
  Files        3351     3351              
  Lines       65037    65038       +1     
  Branches    10474    10475       +1     
==========================================
+ Hits        43793    43808      +15     
+ Misses      18697    18683      -14     
  Partials     2547     2547              
Flag Coverage Δ
Linux_1 31.82% <ø> (ø)
Linux_2 55.57% <ø> (ø)
Linux_3 44.68% <100.00%> (-0.02%) ⬇️
Linux_4 35.04% <ø> (+<0.01%) ⬆️
Windows_1 31.87% <ø> (+0.02%) ⬆️
Windows_2 55.53% <ø> (ø)
Windows_3 44.70% <100.00%> (+<0.01%) ⬆️
Windows_4 35.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhyuanqi zhyuanqi force-pushed the default-icon branch 3 times, most recently from c631bff to a23837b Compare March 21, 2024 02:28
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
@xinruiba xinruiba merged commit 4a8e3e8 into opensearch-project:main Mar 21, 2024
77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 21, 2024
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
(cherry picked from commit 4a8e3e8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Flyingliuhub pushed a commit that referenced this pull request Mar 21, 2024
…) (#6235)

Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
(cherry picked from commit 4a8e3e8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants