Add icon in datasource table page to show the default datasource #6231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
zhyuanqi
force-pushed
the
default-icon
branch
3 times, most recently
from
c5bdaee
to
6ccabca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6231 +/- ##
==========================================
+ Coverage 67.33% 67.35% +0.02%
==========================================
Files 3351 3351
Lines 65037 65038 +1
Branches 10474 10475 +1
==========================================
+ Hits 43793 43808 +15
+ Misses 18697 18683 -14
Partials 2547 2547
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
reviewed
Mar 21, 2024
src/plugins/data_source_management/public/components/data_source_table/data_source_table.tsx
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Mar 21, 2024
zhyuanqi
force-pushed
the
default-icon
branch
3 times, most recently
from
c631bff
to
a23837b
Compare
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
xinruiba
approved these changes
Mar 21, 2024
ruanyl
approved these changes
Mar 21, 2024
xinruiba
added
multiple datasource
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> (cherry picked from commit 4a8e3e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Flyingliuhub
pushed a commit
that referenced
this pull request
Mar 21, 2024
…) (#6235) Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> (cherry picked from commit 4a8e3e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add icon in datasource table page to show the default datasource
Issues Resolved
Screenshot
Screen.Recording.2024-03-20.at.6.03.44.PM.mov
Testing the changes
Check List
yarn test:jestyarn test:jest_integration