-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple DataSource] Codebase maintenance involves updating typos and removing unused imported packages #6238
[Multiple DataSource] Codebase maintenance involves updating typos and removing unused imported packages #6238
Conversation
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6238 +/- ##
==========================================
+ Coverage 67.33% 67.34% +0.01%
==========================================
Files 3352 3352
Lines 65082 65082
Branches 10486 10486
==========================================
+ Hits 43824 43831 +7
+ Misses 18703 18699 -4
+ Partials 2555 2552 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @xinruiba for fixing this. |
Created an issue for improving our link checker for unused imports. #6249 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great maintenance work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xinruiba Thanks for these changes! I'm a little confused about the testing the changes section though. How does the testing the changes section relate to this PR? |
Hey @ashwin-pc, thanks to the comments. I include a full end-to-end testing scenario in the testing section to prevent any potential regressions in MD caused by this name change :) Thanks~ |
…d removing unused imported packages (#6238) * [MD] Fix typo and remove unused imported package Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update chagefile.md Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com> (cherry picked from commit 6c25f2d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…d removing unused imported packages (#6238) (#6263) * [MD] Fix typo and remove unused imported package Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update chagefile.md Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com> (cherry picked from commit 6c25f2d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Description
Codebase maintenance involves updating typos and removing unused imported packages.
Issues Resolved
#6142
Screenshot
UsernamePasswordTesting-typoFix.mov
Testing the changes
In this video, we test Username and Password auth type by executing following steps:
Also test registered auth type locally and works fine. Verified no regressions.
Thanks
Check List
yarn test:jest
yarn test:jest_integration