Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple DataSource] Codebase maintenance involves updating typos and removing unused imported packages #6238

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

xinruiba
Copy link
Member

@xinruiba xinruiba commented Mar 21, 2024

Description

Codebase maintenance involves updating typos and removing unused imported packages.

Issues Resolved

#6142

Screenshot

UsernamePasswordTesting-typoFix.mov

Testing the changes

In this video, we test Username and Password auth type by executing following steps:

  1. Fill in title, url, auth info into dataSource creation form
  2. Click on "Test connection" and test connection success
  3. Click on "Create DataSource" and dataSource creation success
  4. Navigate to home page and successfully add sample data into newly created dataSource
  5. Switch to dashboard tab and able to see dashboards successfully

Also test registered auth type locally and works fine. Verified no regressions.

Thanks

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
@xinruiba xinruiba changed the title [Multiple DataSource] Fix typo and remove unused imported packages [Multiple DataSource] Codebase maintenance involves updating typos and removing unused imported packages Mar 21, 2024
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (312075c) to head (e50e144).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6238      +/-   ##
==========================================
+ Coverage   67.33%   67.34%   +0.01%     
==========================================
  Files        3352     3352              
  Lines       65082    65082              
  Branches    10486    10486              
==========================================
+ Hits        43824    43831       +7     
+ Misses      18703    18699       -4     
+ Partials     2555     2552       -3     
Flag Coverage Δ
Linux_1 31.82% <ø> (ø)
Linux_2 55.57% <ø> (ø)
Linux_3 44.74% <100.00%> (+<0.01%) ⬆️
Linux_4 35.03% <0.00%> (ø)
Windows_1 31.84% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 44.74% <100.00%> (ø)
Windows_4 35.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flyingliuhub
Copy link
Member

Thanks @xinruiba for fixing this.

@tianleh
Copy link
Member

tianleh commented Mar 22, 2024

Created an issue for improving our link checker for unused imports. #6249

Copy link
Member

@tianleh tianleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great maintenance work!

Copy link
Contributor

@yujin-emma yujin-emma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashwin-pc
Copy link
Member

@xinruiba Thanks for these changes! I'm a little confused about the testing the changes section though. How does the testing the changes section relate to this PR?

@xinruiba
Copy link
Member Author

xinruiba commented Mar 22, 2024

@xinruiba Thanks for these changes! I'm a little confused about the testing the changes section though. How does the testing the changes section relate to this PR?

Hey @ashwin-pc, thanks to the comments.

I include a full end-to-end testing scenario in the testing section to prevent any potential regressions in MD caused by this name change :)

Thanks~

@xinruiba xinruiba merged commit 6c25f2d into opensearch-project:main Mar 25, 2024
68 checks passed
@xinruiba xinruiba deleted the xinrui_DSM_typofix branch March 25, 2024 19:21
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
…d removing unused imported packages (#6238)

* [MD] Fix typo and remove unused imported package

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

* Update chagefile.md

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

---------

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
(cherry picked from commit 6c25f2d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
xinruiba added a commit that referenced this pull request Apr 3, 2024
…d removing unused imported packages (#6238) (#6263)

* [MD] Fix typo and remove unused imported package

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

* Update chagefile.md

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

---------

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
(cherry picked from commit 6c25f2d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants