Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Remove arrow down icon from data source selectable component #6257

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Mar 25, 2024

Description

This change is part of #6216 to remove arrowdown icon from data source selectable component

Issues Resolved

Screenshot

removeicon.mp4

Testing the changes

After removing the arrow down icon, the data source selectable component renders correctly

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lu Yu <nluyu@amazon.com>
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (4f1884b) to head (809f68b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6257   +/-   ##
=======================================
  Coverage   67.35%   67.35%           
=======================================
  Files        3353     3353           
  Lines       65083    65083           
  Branches    10483    10483           
=======================================
+ Hits        43837    43839    +2     
+ Misses      18695    18694    -1     
+ Partials     2551     2550    -1     
Flag Coverage Δ
Linux_1 31.82% <ø> (ø)
Linux_2 55.57% <ø> (ø)
Linux_3 44.83% <ø> (-0.01%) ⬇️
Linux_4 35.03% <ø> (ø)
Windows_1 31.84% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 44.85% <ø> (+<0.01%) ⬆️
Windows_4 35.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Mar 25, 2024
@AMoo-Miki
Copy link
Collaborator

@BionIT can you please add a changelog entry for visual enhancement to data source selection?

Signed-off-by: Lu Yu <nluyu@amazon.com>
@BionIT BionIT changed the title [Multiple Datasource] Remove arrowdown icon from data source selectable component [Multiple Datasource] Remove arrow down icon from data source selectable component Mar 25, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
@BionIT
Copy link
Collaborator Author

BionIT commented Mar 25, 2024

@BionIT can you please add a changelog entry for visual enhancement to data source selection?

done! Thanks @AMoo-Miki ! One question, for improvement for unreleased change, do we need to add change log as well?

Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
@BionIT BionIT merged commit 74e0df3 into opensearch-project:main Mar 26, 2024
69 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6257-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74e0df3b86e5d70b11a7c2eb03082b09e0f985c5
# Push it to GitHub
git push --set-upstream origin backport/backport-6257-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6257-to-2.x.

BionIT added a commit to BionIT/OpenSearch-Dashboards that referenced this pull request Apr 2, 2024
…ble component (opensearch-project#6257)

* remove arrowdown icon from data source selector

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

* update snapshot

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT added a commit that referenced this pull request Apr 3, 2024
…ble component (#6257) (#6319)

* remove arrowdown icon from data source selector



* add change log



* update snapshot



---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants