Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Relax the use of ignoreVersionMismatch #6354

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[Backport 2.x] Relax the use of ignoreVersionMismatch #6354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions src/core/server/opensearch/opensearch_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,19 +129,7 @@ export const configSchema = schema.object({
),
apiVersion: schema.string({ defaultValue: DEFAULT_API_VERSION }),
healthCheck: schema.object({ delay: schema.duration({ defaultValue: 2500 }) }),
ignoreVersionMismatch: schema.conditional(
schema.contextRef('dev'),
false,
schema.boolean({
validate: (rawValue) => {
if (rawValue === true) {
return '"ignoreVersionMismatch" can only be set to true in development mode';
}
},
defaultValue: false,
}),
schema.boolean({ defaultValue: false })
),
ignoreVersionMismatch: schema.boolean({ defaultValue: false }),
disablePrototypePoisoningProtection: schema.maybe(schema.boolean({ defaultValue: false })),
});

Expand Down Expand Up @@ -216,7 +204,7 @@ export class OpenSearchConfig {
public readonly healthCheckDelay: Duration;

/**
* Whether to allow opensearch-dashboards to connect to a non-compatible opensearch node.
* Whether to allow opensearch-dashboards to connect to an opensearch node of a different version.
*/
public readonly ignoreVersionMismatch: boolean;

Expand Down
Loading