-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation succeed as long as status code in response is 200 #6399
Validation succeed as long as status code in response is 200 #6399
Conversation
4fdf928
to
e53b3dc
Compare
Signed-off-by: cliu123 <lc12251109@gmail.com>
e53b3dc
to
b5d79e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6399 +/- ##
===========================================
- Coverage 55.58% 45.05% -10.54%
===========================================
Files 1199 1650 +451
Lines 24259 33471 +9212
Branches 4087 6359 +2272
===========================================
+ Hits 13485 15079 +1594
- Misses 10133 17225 +7092
- Partials 641 1167 +526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bbarani @gaiksaya @kavilla Could we include this fix in 2.13.1? |
This fix will be backported to 2.13 branch for next patch release of 2.13.x. |
@xinruiba @bandinib-amzn @Flyingliuhub @ZilongX @BionIT @zhongnansu please help to take a look when you got time |
LGTM, thanks for this change |
Signed-off-by: cliu123 <lc12251109@gmail.com> (cherry picked from commit 476cffc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Signed-off-by: cliu123 <lc12251109@gmail.com> (cherry picked from commit 476cffc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…6447) Signed-off-by: cliu123 <lc12251109@gmail.com> (cherry picked from commit 476cffc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Description
Data source validation should pass as long as response code is
200
even if response body is empty, for example:Issues Resolved
#6396
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration