Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test in PR 6360 #6411

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix test in PR 6360 #6411

merged 1 commit into from
Apr 11, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Apr 11, 2024 •
edited
Loading

Description

This PR updates two snapshots

  1. src/plugins/dashboard/public/application/components/dashboard_top_nav/dashboard_top_nav.test.tsx this one breaks due to [OSCI] Removed KUI usage in visualizations -- Completion of Original PR #6360
  2. src/plugins/dashboard/public/application/components/dashboard_listing/dashboard_listing.test.tsx this one breaks due to [OSCI] Removed KUI usage in visualizations -- Completion of Original PR #6360

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added v2.14.0 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed distinguished-contributor labels Apr 11, 2024
@ananzh
Copy link
Member Author

ananzh commented Apr 11, 2024

Link Check is failed in all recent PRs. It is not caused by this one.

@ananzh ananzh mentioned this pull request Apr 11, 2024
Merged
7 tasks
@ananzh
Fix tests in 6360
6bcd18b 
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@bandinib-amzn bandinib-amzn mentioned this pull request Apr 11, 2024
Merged
7 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.62%. Comparing base (85df662) to head (6bcd18b).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6411      +/-   ##
==========================================
+ Coverage   55.58%   55.62%   +0.03%     
==========================================
  Files        1199     1199              
  Lines       24259    24259              
  Branches     4087     4087              
==========================================
+ Hits        13485    13493       +8     
+ Misses      10133    10124       -9     
- Partials      641      642       +1
Flag Coverage Δ
Linux_2 55.62% <ø> (?)
Windows_2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yujin-emma
Copy link
Contributor

lint checker is failed, could you please fix it

@ananzh
Copy link
Member Author

ananzh commented Apr 11, 2024

@yujin-emma lint checker failed issue. not related to the #6360 . Will fix in a separate PR.
#6412

@ananzh ananzh merged commit 79ddfb9 into opensearch-project:main Apr 11, 2024
67 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@github-actions
Fix tests in 6360 (#6411)
d96c49c 
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 79ddfb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 11, 2024
Merged
@ananzh ananzh self-assigned this Apr 12, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@github-actions
Fix tests in 6360 (#6411)
8ad7ef6 
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 79ddfb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 30, 2024
Merged
ananzh added a commit that referenced this pull request Apr 30, 2024
@opensearch-trigger-bot @github-actions @ananzh
Fix tests in 6360 (#6411) (#6414)
d0eeb31 
(cherry picked from commit 79ddfb9)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@github-actions @ananzh
Fix tests in 6360 (#6411) (#6414)
9971523 
(cherry picked from commit 79ddfb9)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit d0eeb31)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Apr 30, 2024
@opensearch-trigger-bot @github-actions
Fix tests in 6360 (#6411) (#6693)
71e2a45 
(cherry picked from commit 79ddfb9)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

Assignees

@ananzh ananzh

Labels
backport 2.x backport 2.14 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry test:unit v2.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @yujin-emma @AMoo-Miki @ashwin-pc