Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link-checker and clean up ignore-list #6425

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Apr 12, 2024

Description

Bump the link checker action, rename the ignore list file to be picked up by lychee, and clean up the content of the ignore list.

Also updated selenium docs links.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.60%. Comparing base (85df662) to head (62a4610).
Report is 12 commits behind head on main.

❗ Current head 62a4610 differs from pull request most recent head e72cbec. Consider uploading reports for the commit e72cbec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6425      +/-   ##
==========================================
+ Coverage   55.58%   55.60%   +0.01%     
==========================================
  Files        1199     1199              
  Lines       24259    24265       +6     
  Branches     4087     4093       +6     
==========================================
+ Hits        13485    13493       +8     
+ Misses      10133    10128       -5     
- Partials      641      644       +3     
Flag Coverage Δ
Linux_2 55.60% <ø> (?)
Windows_2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki force-pushed the fix-link-checker branch 8 times, most recently from e7af1a9 to 405440c Compare April 12, 2024 08:52
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Copy link
Collaborator Author

While the workflow itself doesn't need backporting because it only runs in main, it might be worth backporting for the other files where selenium urls were updated.

@ashwin-pc
Copy link
Member

@AMoo-Miki why do we need this?

@AMoo-Miki
Copy link
Collaborator Author

@AMoo-Miki why do we need this?

A lot has changed in the action and its nested dep but most important are:

  • reduced false positives
  • reduced false negatives
  • better ignore-list handling
  • better control of retries, back off, and failing

@AMoo-Miki AMoo-Miki merged commit fa3bedb into opensearch-project:main Apr 22, 2024
84 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit fa3bedb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kavilla pushed a commit that referenced this pull request Apr 26, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit fa3bedb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants