[MD]Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector #6477

zhongnansu · 2024-04-16T08:16:19Z

Description

use const DataSourceSelector = dataSourceManagement.ui.DataSourceSelector instead of direct import DataSourceSelector.
remove hideLocalCluster and uiSetting props, since when using those components, data source management plugin side has logic to always pass and overwrite those 2 props.

Issues Resolved

partially fix #6369

Screenshot

iShot_2024-04-16_14.03.23.mp4

Testing the changes

enable datasource from yml
create 2 datasources ds1, ds2, for testing
navigate to dev_tool console, click data source selector dropdown, and expect to see
- local cluster, ds1, ds2 should show up as option
- a option with default label show up
- change default data source, the change will be reflected in the data source selector
set data_source.hideLocalCluster: true in yml, and go to dev tool console again
- local cluster option should be hidden
disable data source feature flag,
- data source selector will not display on dev tool console page.

Changelog

refactor: Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-04-16T09:05:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.91%. Comparing base (d2d410b) to head (62128f9).
Report is 6 commits behind head on main.

❗ Current head 62128f9 differs from pull request most recent head c4e81dd. Consider uploading reports for the commit c4e81dd to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6477      +/-   ##
==========================================
+ Coverage   32.93%   34.91%   +1.98%     
==========================================
  Files        2260     1914     -346     
  Lines       45769    37007    -8762     
  Branches     7200     6796     -404     
==========================================
- Hits        15075    12922    -2153     
+ Misses      29984    23227    -6757     
- Partials      710      858     +148

Flag	Coverage Δ
Linux_1	`?`
Windows_4	`34.91% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BionIT · 2024-04-16T20:41:31Z

Can we add steps for the testing and screenshots?

zhongnansu · 2024-04-16T21:19:27Z

Can we add steps for the testing and screenshots?

sure, added test steps and a video

github-actions · 2024-04-16T21:20:09Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions · 2024-04-16T21:20:19Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions · 2024-04-16T21:30:51Z

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 6477.yml under folder changelogs/fragments to complete this PR. File still missing.

github-actions · 2024-04-16T22:14:11Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "[MD]Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2024-04-16T22:43:33Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "refactor". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

… DataSourceSelector Signed-off-by: Zhongnan Su <szhongna@amazon.com>

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

ZilongX · 2024-04-17T22:36:21Z

pick up latest main and re-running all checks

…ourceSelector (#6477) * Refactor dev tool to use dataSourceManagement.ui interfaces to obtain DataSourceSelector Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit fb76ee9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ourceSelector (#6477) (#6521) * Refactor dev tool to use dataSourceManagement.ui interfaces to obtain DataSourceSelector (cherry picked from commit fb76ee9) Signed-off-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions bot added the distinguished-contributor label Apr 16, 2024

zhongnansu force-pushed the dev-tool-md-refactor branch from 4b0c15f to b67b059 Compare April 16, 2024 08:35

zhongnansu force-pushed the dev-tool-md-refactor branch from b67b059 to 62128f9 Compare April 16, 2024 19:42

zhongnansu marked this pull request as ready for review April 16, 2024 19:42

zhongnansu requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT and xinruiba as code owners April 16, 2024 19:42

zhongnansu added backport 2.x multiple datasource multiple datasource project v2.14.0 labels Apr 16, 2024

github-actions bot added the failed changeset label Apr 16, 2024

BionIT previously approved these changes Apr 16, 2024

View reviewed changes

github-actions bot added the failed changeset label Apr 16, 2024

opensearch-project deleted a comment from github-actions bot Apr 16, 2024

github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Apr 16, 2024

github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Apr 16, 2024

opensearch-changeset-bot bot added a commit to zhongnansu/OpenSearch-Dashboards that referenced this pull request Apr 17, 2024

Changeset file for PR opensearch-project#6477 created/updated

d3f803e

github-actions bot removed the failed changeset label Apr 17, 2024

opensearch-changeset-bot bot dismissed BionIT’s stale review via d3f803e April 17, 2024 01:28

zhongnansu requested a review from BionIT April 17, 2024 01:29

zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this pull request Apr 17, 2024

Changeset file for PR opensearch-project#6477 created/updated

4cfce11

zhongnansu force-pushed the dev-tool-md-refactor branch from d3f803e to 4cfce11 Compare April 17, 2024 18:05

zhongnansu and others added 3 commits April 17, 2024 21:16

Refactor dev tool to use dataSourceManagement.ui interfaces to obtain…

f985f5d

… DataSourceSelector Signed-off-by: Zhongnan Su <szhongna@amazon.com>

Changeset file for PR opensearch-project#6477 created/updated

982436b

fix test

c238e2f

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

zhongnansu force-pushed the dev-tool-md-refactor branch from 4cfce11 to c238e2f Compare April 17, 2024 21:16

BionIT approved these changes Apr 17, 2024

View reviewed changes

Merge branch 'main' into dev-tool-md-refactor

c4e81dd

huyaboo approved these changes Apr 17, 2024

View reviewed changes

ZilongX approved these changes Apr 18, 2024

View reviewed changes

zhongnansu merged commit fb76ee9 into opensearch-project:main Apr 18, 2024
65 checks passed

opensearch-trigger-bot bot mentioned this pull request Apr 18, 2024

[Backport 2.x] [MD]Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector #6521

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MD]Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector #6477

[MD]Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector #6477

zhongnansu commented Apr 16, 2024 •

edited

Loading

codecov bot commented Apr 16, 2024 •

edited

Loading

BionIT commented Apr 16, 2024

zhongnansu commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

ZilongX commented Apr 17, 2024

[MD]Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector #6477

[MD]Refactor dev tool to use dataSourceManagement.ui API to get DataSourceSelector #6477

Conversation

zhongnansu commented Apr 16, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

codecov bot commented Apr 16, 2024 • edited Loading

Codecov Report

BionIT commented Apr 16, 2024

zhongnansu commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

❌ Invalid Changelog Heading

github-actions bot commented Apr 16, 2024

❌ Invalid Changelog Heading

github-actions bot commented Apr 16, 2024

❌ Changeset File Not Added Yet

github-actions bot commented Apr 16, 2024

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Apr 16, 2024

❌ Invalid Prefix For Manual Changeset Creation

ZilongX commented Apr 17, 2024

zhongnansu commented Apr 16, 2024 •

edited

Loading

codecov bot commented Apr 16, 2024 •

edited

Loading