-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Copy selected/all saved objects #6478
[Workspace] Copy selected/all saved objects #6478
Conversation
27cb3dd
to
bbf4cb1
Compare
Signed-off-by: yubonluo <yubonluo@amazon.com>
bbf4cb1
to
41d33da
Compare
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
==========================================
+ Coverage 63.96% 64.02% +0.06%
==========================================
Files 3597 3603 +6
Lines 78262 78477 +215
Branches 12339 12382 +43
==========================================
+ Hits 50057 50244 +187
- Misses 25185 25207 +22
- Partials 3020 3026 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, left some comments, should not be blocker
...jects_management/public/management_section/objects_table/components/duplicate_modal.test.tsx
Outdated
Show resolved
Hide resolved
...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
Outdated
Show resolved
Hide resolved
...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
Outdated
Show resolved
Hide resolved
...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
Outdated
Show resolved
Hide resolved
...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6478-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9abde5c91b86bdcedde315f8ea7f650ffadac20e
# Push it to GitHub
git push --set-upstream origin backport/backport-6478-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-6478-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9abde5c91b86bdcedde315f8ea7f650ffadac20e
# Push it to GitHub
git push --set-upstream origin backport/backport-6478-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16 Then, create a pull request where the |
* [Worksapce][UI] duplicate selected/all saved objects Signed-off-by: yubonluo <yubonluo@amazon.com> * fix test error Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code transfer memory Signed-off-by: yubonluo <yubonluo@amazon.com> * revert useless modify Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * add test id Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #6478 created/updated * According the last mockup to optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Optimize user experience Signed-off-by: yubonluo <yubonluo@amazon.com> * Solve the test snapshot error Signed-off-by: yubonluo <yubonluo@amazon.com> * modefy the ui text Signed-off-by: yubonluo <yubonluo@amazon.com> * support copy result flyout Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9abde5c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-6478-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9abde5c91b86bdcedde315f8ea7f650ffadac20e
# Push it to GitHub
git push --set-upstream origin backport/backport-6478-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16 Then, create a pull request where the |
* [Worksapce][UI] duplicate selected/all saved objects * fix test error * optimize code transfer memory * revert useless modify * optimize the code * add test id * Changeset file for PR #6478 created/updated * According the last mockup to optimize the code * Delete useless code * Optimize the code * optimize code * delete useless code * Optimize user experience * Solve the test snapshot error * modefy the ui text * support copy result flyout * optimize the code * optimize the code --------- (cherry picked from commit 9abde5c) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…opensearch-project#7429) * [Worksapce][UI] duplicate selected/all saved objects * fix test error * optimize code transfer memory * revert useless modify * optimize the code * add test id * Changeset file for PR opensearch-project#6478 created/updated * According the last mockup to optimize the code * Delete useless code * Optimize the code * optimize code * delete useless code * Optimize user experience * Solve the test snapshot error * modefy the ui text * support copy result flyout * optimize the code * optimize the code --------- (cherry picked from commit 9abde5c) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR follows up #6288 which can be used to duplicate saved objects among workspaces.
Only UI change in this PR.
Issues Resolved
#6388
Screenshot
2024-06-21.14.59.04.mp4
There are three types of duplicate buttons on the saved objects management page.
If the user clicks the duplicate button, a modal window will pop up as follows:
Changelog
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration