-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add empty state and test except the aggregated view #6499
Conversation
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6499.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6499.yml under folder changelogs/fragments to complete this PR. File still missing. |
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6499 +/- ##
===========================================
- Coverage 45.18% 32.74% -12.44%
===========================================
Files 1656 2257 +601
Lines 33591 45617 +12026
Branches 6385 7159 +774
===========================================
- Hits 15177 14937 -240
- Misses 17244 29981 +12737
+ Partials 1170 699 -471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -180,6 +183,9 @@ export class DataSourceSelectable extends React.Component< | |||
'title', | |||
'auth.type', | |||
]); | |||
if (fetchedDataSources?.length === 0 && this.props.hideLocalCluster) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of evaluate fetechedDataSources, we should evaluate the options after filter, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, updated
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6499.yml under folder changelogs/fragments to complete this PR. File still missing. |
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6499-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c4af2ab583158c634ec73ad5aa1aa795b572ffa8
# Push it to GitHub
git push --set-upstream origin backport/backport-6499-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* add empty state and test except the aggregated view Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update change log Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * adjust the order for filter options and empty state check Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * fix lint Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> --------- Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com> (cherry picked from commit c4af2ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* add empty state and test except the aggregated view Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update change log Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * adjust the order for filter options and empty state check Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * fix lint Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> --------- Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com> (cherry picked from commit c4af2ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Issues Resolved
#6420
Screenshot
when there is no remote data source but do not hide local cluster
when there is no remote data source but do hide local cluster
when there is data source but filter out, still show empty-state
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration