Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] add popover for Data Source empty state #6514

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

yujin-emma
Copy link
Contributor

@yujin-emma yujin-emma commented Apr 17, 2024

Description

Add popover for empty state

Issues Resolved

Screenshot

Testing the change

Test data source view

empty-state-popover-data-source-view

Test data source selectable

empty-state-popover-selectable

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 6514.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@yujin-emma yujin-emma marked this pull request as ready for review April 17, 2024 18:36
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Apr 17, 2024
BionIT
BionIT previously approved these changes Apr 17, 2024
zhongnansu
zhongnansu previously approved these changes Apr 17, 2024
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix the PR title to not swallow words?

@yujin-emma yujin-emma changed the title [Multiple Datasource] add popover for empty state, add it in datasource view and selectable… [Multiple Datasource] add popover for empty state Apr 17, 2024
@yujin-emma yujin-emma changed the title [Multiple Datasource] add popover for empty state [Multiple Datasource] add popover for Data Source empty state Apr 17, 2024
@yujin-emma yujin-emma dismissed stale reviews from zhongnansu and BionIT via 8cc1d96 April 17, 2024 20:57
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
BionIT
BionIT previously approved these changes Apr 17, 2024
yujin-emma and others added 2 commits April 17, 2024 15:33
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 45.21%. Comparing base (d2d410b) to head (4ac4f97).
Report is 6 commits behind head on main.

Files Patch % Lines
...ublic/components/no_data_source/no_data_source.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6514       +/-   ##
===========================================
+ Coverage   32.93%   45.21%   +12.28%     
===========================================
  Files        2260     1658      -602     
  Lines       45769    33689    -12080     
  Branches     7200     6409      -791     
===========================================
+ Hits        15075    15234      +159     
+ Misses      29984    17270    -12714     
- Partials      710     1185      +475     
Flag Coverage Δ
Linux_1 ?
Windows_3 45.21% <90.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinruiba xinruiba merged commit d8ddc1a into opensearch-project:main Apr 17, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6514-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8ddc1a0e8a621de7986c1f0cedb0efeb92154ec
# Push it to GitHub
git push --set-upstream origin backport/backport-6514-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6514-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6514-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8ddc1a0e8a621de7986c1f0cedb0efeb92154ec
# Push it to GitHub
git push --set-upstream origin backport/backport-6514-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6514-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6514-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8ddc1a0e8a621de7986c1f0cedb0efeb92154ec
# Push it to GitHub
git push --set-upstream origin backport/backport-6514-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6514-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2024
* add empty state popover

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix failed test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
(cherry picked from commit d8ddc1a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ZilongX pushed a commit that referenced this pull request Apr 18, 2024
…#6540)

* add empty state popover

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix failed test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
(cherry picked from commit d8ddc1a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@yujin-emma yujin-emma deleted the add-popover branch June 12, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants