-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For selectable component, remove group label and close popover after selection #6515
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR. File still missing. |
1 similar comment
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR. File still missing. |
06885c8
to
6888f78
Compare
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR. File still missing. |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
…selection Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6515 +/- ##
===========================================
+ Coverage 32.93% 55.63% +22.70%
===========================================
Files 2260 1201 -1059
Lines 45769 24289 -21480
Branches 7200 4098 -3102
===========================================
- Hits 15075 13514 -1561
+ Misses 29984 10129 -19855
+ Partials 710 646 -64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6515-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b90e9bac2ee646d7e922fc5f64ccc0d2ca11861
# Push it to GitHub
git push --set-upstream origin backport/backport-6515-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…selection (#6515) (#6536) Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> (cherry picked from commit 0b90e9b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
For selectable component, remove group label and close popover after selection
Issues Resolved
Screenshot
Screen.Recording.2024-04-17.at.1.16.25.PM.mov
Testing the changes
See videos for testing
Changelog
Check List
yarn test:jest
yarn test:jest_integration