Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vega visualization error message not been formatted #6777

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented May 13, 2024

Description

With unsupported type ppl
The error message before:
url: {"%type%": "${type}"} is not supported
It should be:
url: {"%type%": "ppl"} is not supported

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: error message is not formatted in vis_type_vega url parser.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 6777.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.38%. Comparing base (b839da1) to head (9d3725f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6777   +/-   ##
=======================================
  Coverage   67.38%   67.38%           
=======================================
  Files        3443     3443           
  Lines       67788    67788           
  Branches    11031    11031           
=======================================
  Hits        45677    45677           
  Misses      19440    19440           
  Partials     2671     2671           
Flag Coverage Δ
Linux_1 33.07% <ø> (ø)
Linux_2 55.13% <ø> (ø)
Linux_3 45.15% <ø> (ø)
Linux_4 34.81% <ø> (ø)
Windows_1 33.09% <ø> (ø)
Windows_2 55.10% <ø> (ø)
Windows_3 45.15% <ø> (-0.02%) ⬇️
Windows_4 34.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SuZhou-Joe
SuZhou-Joe previously approved these changes May 13, 2024
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

4 similar comments
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but does this require a changeset file due to changelog entry?

manasvinibs
manasvinibs previously approved these changes May 20, 2024
zhyuanqi
zhyuanqi previously approved these changes May 22, 2024
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@ruanyl ruanyl requested a review from mengweieric as a code owner May 23, 2024 09:25
@ruanyl
Copy link
Member Author

ruanyl commented May 23, 2024

@zhyuanqi @SuZhou-Joe @manasvinibs Could you give it an approval again? adding changeset file dismissed your approvals.

@ruanyl ruanyl merged commit 8d50974 into opensearch-project:main May 27, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 27, 2024
* fix vega visualization error message not been formatted

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8d50974)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request May 27, 2024
* fix vega visualization error message not been formatted

---------



(cherry picked from commit 8d50974)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
…roject#6777)

* fix vega visualization error message not been formatted

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants