Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace]Import sample data to current workspace #6826

Merged
merged 1 commit into from
May 27, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3e9a159 from #6105.

* Import sample data to workspace

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Enable workspace ui plugin

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Add changelog for import sample data to current workspace

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: register sample data as standalone app (#8)

* feat: register sample data as standalone app

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use props to pass homeLink

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Retrieve workspace id from request

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove workspace id in query

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Move changelog to fragments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Fix sample data list unit tests

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove no need workspaces deps

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove manual created changelogs

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #6105 created/updated

* Enable sample data in workspace overview page (#9)

* enable sample data in workspace overview page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* add comments for empty id

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add unit tests for getFinalSavedObjects in data sets util file

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Add unit tests for renderImportSampleDataApp destroy

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Address PR comments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove history listen in renderImportSampleDataApp

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove Route for workspace import sample data entry point

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 3e9a159)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 83.90805% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.41%. Comparing base (ecfaed5) to head (2131598).

Files Patch % Lines
src/plugins/home/public/plugin.ts 16.66% 10 Missing ⚠️
...home/server/services/sample_data/data_sets/util.ts 95.23% 0 Missing and 2 partials ⚠️
.../services/sample_data/data_sets/ecommerce/index.ts 0.00% 1 Missing ⚠️
...erver/services/sample_data/data_sets/logs/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6826      +/-   ##
==========================================
- Coverage   67.60%   67.41%   -0.19%     
==========================================
  Files        3427     3442      +15     
  Lines       67357    67775     +418     
  Branches    10983    11011      +28     
==========================================
+ Hits        45535    45691     +156     
- Misses      19157    19419     +262     
  Partials     2665     2665              
Flag Coverage Δ
Linux_1 33.07% <7.69%> (-0.01%) ⬇️
Linux_2 55.16% <ø> (ø)
Linux_3 45.20% <7.69%> (-0.01%) ⬇️
Linux_4 34.96% <83.90%> (+0.08%) ⬆️
Windows_1 33.09% <7.69%> (-0.01%) ⬇️
Windows_2 55.13% <ø> (ø)
Windows_3 45.21% <7.69%> (-0.02%) ⬇️
Windows_4 34.96% <83.90%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 0af3a00 into 2.x May 27, 2024
92 of 93 checks passed
@github-actions github-actions bot deleted the backport/backport-6105-to-2.x branch May 27, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports first-time-contributor v2.15.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants