-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Only OSD admin can create workspace #6831
Merged
SuZhou-Joe
merged 27 commits into
opensearch-project:main
from
yubonluo:main-create-workspace-OSDAdmin
Jun 4, 2024
Merged
[Workspace] Only OSD admin can create workspace #6831
SuZhou-Joe
merged 27 commits into
opensearch-project:main
from
yubonluo:main-create-workspace-OSDAdmin
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
May 24, 2024 09:46
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6831 +/- ##
==========================================
+ Coverage 67.41% 67.43% +0.01%
==========================================
Files 3444 3444
Lines 67839 67847 +8
Branches 11033 11035 +2
==========================================
+ Hits 45734 45751 +17
+ Misses 19439 19429 -10
- Partials 2666 2667 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
reviewed
May 27, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into main-create-workspace-OSDAdmin
…OpenSearch-Dashboards into main-create-workspace-OSDAdmin
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into main-create-workspace-OSDAdmin
SuZhou-Joe
reviewed
May 31, 2024
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
…OpenSearch-Dashboards into main-create-workspace-OSDAdmin
SuZhou-Joe
reviewed
May 31, 2024
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
CC @SuZhou-Joe @ruanyl If you don‘t have any concerns about this CR, could you please help me approve it? |
SuZhou-Joe
previously approved these changes
Jun 3, 2024
virajsanghvi
reviewed
Jun 3, 2024
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Show resolved
Hide resolved
...kspace/server/saved_objects/integration_tests/workspace_saved_objects_client_wrapper.test.ts
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
…OpenSearch-Dashboards into main-create-workspace-OSDAdmin
ruanyl
approved these changes
Jun 4, 2024
SuZhou-Joe
approved these changes
Jun 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Only OSD admin can create workspace Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #6831 created/updated * Changeset file for PR #6831 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * add integration tests Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * add overwrite check Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Add the logic of whether to update the operation Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 32fbe18) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Only OSD admin can create workspace * Changeset file for PR #6831 created/updated * Changeset file for PR #6831 created/updated * optimize the code * delete useless code * add integration tests * optimize the code * delete useless code * optimize the code * optimize the code * optimize the code * add overwrite check * optimize the code * optimize the code * Add the logic of whether to update the operation * optimize the code * Optimize the code * Optimize the code --------- (cherry picked from commit 32fbe18) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only OSD admin can create workspace
Issues Resolved
#6830
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration